Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2627093003: Reuse context menu in StaticHTMLViewController (Closed)
Patch Set: fix DEPS Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index 96a7e1384d5a4ca4e19d7957b06151b6aeffe29a..cc95af6fdf78c249300cf8a240ee958c35a18bde 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -97,6 +97,7 @@
#import "ios/chrome/browser/ui/commands/reading_list_add_command.h"
#import "ios/chrome/browser/ui/commands/show_mail_composer_command.h"
#import "ios/chrome/browser/ui/context_menu/context_menu_coordinator.h"
+#import "ios/chrome/browser/ui/context_menu/context_menu_delegate.h"
#import "ios/chrome/browser/ui/contextual_search/contextual_search_controller.h"
#import "ios/chrome/browser/ui/contextual_search/contextual_search_mask_view.h"
#import "ios/chrome/browser/ui/contextual_search/contextual_search_metrics.h"
@@ -293,6 +294,7 @@ NSString* const kReadingListSnackbarCategory = @"ReadingListSnackbarCategory";
} // anonymous namespace
@interface BrowserViewController ()<AppRatingPromptDelegate,
+ ContextMenuDelegate,
jif 2017/01/12 17:13:12 Does it make sense to use the CRWWebStateDelegate
Olivier 2017/01/13 10:20:25 I don't think so. CRWWebStateDelegate has other me
ContextualSearchControllerDelegate,
ContextualSearchPanelMotionObserver,
CRWNativeContentProvider,
@@ -2937,7 +2939,8 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
[[[OfflinePageNativeContent alloc] initWithLoader:self
browserState:_browserState
webState:[self currentWebState]
- URL:url] autorelease];
+ URL:url
+ contextMenuDelegate:self] autorelease];
[self setOverScrollActionControllerToStaticNativeContent:
staticNativeController];
nativeController = staticNativeController;
« no previous file with comments | « no previous file | ios/chrome/browser/ui/context_menu/BUILD.gn » ('j') | ios/chrome/browser/ui/context_menu/context_menu_delegate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698