Reuse context menu in StaticHTMLViewController

ios/web/web_state/ui/crw_context_menu_controller.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_WEB_WEB_STATE_UI_CRW_CONTEXT_MENU_CONTROLLER_H_
+#define IOS_WEB_WEB_STATE_UI_CRW_CONTEXT_MENU_CONTROLLER_H_
+
+#import <UIKit/UIKit.h>

[Eugene But (OOO till 7-30), 2017/01/13 16:19:41]

nit: there is nothing from UIKit in this header, importing Foundation is enough

[Olivier, 2017/01/13 18:08:58]

I thought WKWebView needed it.
Done.

+#import <Webkit/Webkit.h>
+
+#import "ios/web/public/block_types.h"
+
+@protocol CRWContextMenuDelegate;
+
+@protocol CRWContextMenuJavaScriptDelegate
+- (void)executeJavaScript:(NSString*)script
+        completionHandler:(web::JavaScriptResultBlock)completionHandler;
+@end
+
+@interface CRWContextMenuController : NSObject

[Eugene But (OOO till 7-30), 2017/01/13 16:19:41]

Per Style Guide please add comments to this class and public method. Things
worth mentioning:
 - webView is not retained and can not be nil
 - javaScriptDelegate can be nil
 - what happens if javaScriptDelegate is nil
 - why clients would want to pass non-nil javaScriptDelegate
 - this class installs gesture recognizers
 - this class has performance implications (JS is executed on every view touch)
 - this class invokes CRWContextMenuDelegate methods only if long press happened
on the main frame (crbug.com/228179)

Maybe other things I missed here?

[Olivier, 2017/01/13 18:08:58]

Done.

+
+- (instancetype)initWithWebView:(WKWebView*)webView
+             javaScriptDelegate:
+                 (id<CRWContextMenuJavaScriptDelegate>)javaScriptDelegate

[Eugene But (OOO till 7-30), 2017/01/13 16:19:41]

You can use CRWJSInjectionEvaluator protocol here, there are not many advantages
in a separate delegate as this code is very isolated.

[Olivier, 2017/01/13 18:08:58]

Done.

+                       delegate:(id<CRWContextMenuDelegate>)delegate
+    NS_DESIGNATED_INITIALIZER;
+
+- (instancetype)init NS_UNAVAILABLE;
+
+@end
+
+#endif  // IOS_WEB_WEB_STATE_UI_CRW_CONTEXT_MENU_CONTROLLER_H_