ios/web/public/web_state/ui/crw_context_menu_delegate.h - Issue 2627093003: Reuse context menu in StaticHTMLViewController

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/public/web_state/ui/crw_context_menu_delegate.h

Issue 2627093003: Reuse context menu in StaticHTMLViewController (Closed)

Patch Set: cleaning Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/browser/ui/static_content/static_html_view_controller.mm ('K') | « ios/web/BUILD.gn ('k') | ios/web/public/web_state/ui/crw_native_content.h » ('j') | ios/web/public/web_state/ui/crw_native_content.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_WEB_PUBLIC_WEB_STATE_UI_CRW_CONTEXT_MENU_DELEGATE_H_

	6 #define IOS_WEB_PUBLIC_WEB_STATE_UI_CRW_CONTEXT_MENU_DELEGATE_H_

	7

	8 #import <WebKit/WebKit.h>

	9

	10 #import "ios/web/public/web_state/context_menu_params.h"

	11

	12 @protocol CRWContextMenuDelegate

	13 - (BOOL)webView:(WKWebView*)webView
	Eugene But (OOO till 7-30) 2017/01/13 16:19:41 Could you please add comments. Things which worth Could you please add comments. Things which worth explaining are: - this is called when user performs a long press gesture on a web view - this method is not called if gesture is performed on iframe (crbug.com/228179) - if result is YES then system context menu will be suppressed - if result is NO then system context menu will show up - clients don't have to show any UI, so this can be used to suppress system context menu Maybe other things I missed here? Olivier 2017/01/13 18:08:58 Added a timing comment when returning YES. Show quoted text On 2017/01/13 16:19:41, Eugene But wrote: > Could you please add comments. Things which worth explaining are: > - this is called when user performs a long press gesture on a web view > - this method is not called if gesture is performed on iframe (crbug.com/228179) > - if result is YES then system context menu will be suppressed > - if result is NO then system context menu will show up > - clients don't have to show any UI, so this can be used to suppress system > context menu > > Maybe other things I missed here? Added a timing comment when returning YES.
	14 handleContextMenu:(const web::ContextMenuParams&)params;

	15 @end

	16

	17 #endif // IOS_WEB_PUBLIC_WEB_STATE_UI_CRW_CONTEXT_MENU_DELEGATE_H_

OLD	NEW