ios/chrome/browser/ui/context_menu/context_menu_delegate.h - Issue 2627093003: Reuse context menu in StaticHTMLViewController

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/context_menu/context_menu_delegate.h

Issue 2627093003: Reuse context menu in StaticHTMLViewController (Closed)

Patch Set: fix DEPS Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/browser/ui/browser_view_controller.mm ('K') | « ios/chrome/browser/ui/context_menu/BUILD.gn ('k') | ios/chrome/browser/ui/reading_list/BUILD.gn » ('j') | ios/chrome/browser/ui/reading_list/offline_page_native_content.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_UI_CONTEXT_MENU_CONTEXT_MENU_DELEGATE_H_

	6 #define IOS_CHROME_BROWSER_UI_CONTEXT_MENU_CONTEXT_MENU_DELEGATE_H_

	7

	8 namespace web {

	9 class WebState;

	10 struct ContextMenuParams;

	11 }

	12

	13 // A delegate that will display a context menu for \|params\|. User choice on this

	14 // menu can trigger a navigation on \|webState\|.

	15 @protocol ContextMenuDelegate<NSObject>

	16 - (BOOL)webState:(web::WebState*)webState
	Eugene But (OOO till 7-30) 2017/01/13 07:16:26 First argument in Objective-C delegate method is a First argument in Objective-C delegate method is always a caller, which is not really the case here. Should this delegate be like this?: @protocol OfflinePageNativeContentDelegate - (BOOL)dfflinePageNativeContent:(OfflinePageNativeContent)nativeContent handleContextMenu:(const web::ContextMenuParams&)params; @end I know that Chrome for iOS code often reuses same delegate protocol for different classes, but that approach have a few issues: - it does not follow Coding Guidelines for Cocoa (which are basis for Google Style Guide) - it increases complexity, because it is harder to reason about the caller Olivier* 2017/01/13 10:20:25 Done. I used the mode generic "native content" ins Show quoted text On 2017/01/13 07:16:26, Eugene But wrote: > First argument in Objective-C delegate method is always a caller, which is not > really the case here. Should this delegate be like this?: > > @protocol OfflinePageNativeContentDelegate > - (BOOL)dfflinePageNativeContent:(OfflinePageNativeContent*)nativeContent > handleContextMenu:(const web::ContextMenuParams&)params; > @end > > I know that Chrome for iOS code often reuses same delegate protocol for > different classes, but that approach have a few issues: > - it does not follow Coding Guidelines for Cocoa (which are basis for Google > Style Guide) > - it increases complexity, because it is harder to reason about the caller Done. I used the mode generic "native content" instead of OfflinePageNativeContent as I don't see any reason to limit to OfflinePageNativeContentDelegate. There is already a nativeContentDelegate, so I added my method there. I can change that if needed.
	17 handleContextMenu:(const web::ContextMenuParams&)params;

	18 @end

	19

	20 #endif // IOS_CHROME_BROWSER_UI_CONTEXT_MENU_CONTEXT_MENU_DELEGATE_H_

OLD	NEW