Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2627083003: Replace reset() arguments with resetWith() invocation. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace reset() arguments with resetWith() invocation. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9d240f8fb138fda87ffdabd72bf3a25f851444a5

Patch Set 1 #

Patch Set 2 : Remove commented code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -85 lines) Patch
M pkg/analyzer/test/generated/all_the_rest_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/declaration_resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/non_hint_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 1 6 chunks +26 lines, -39 lines 0 comments Download
M pkg/analyzer/test/generated/simple_resolver_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 20 chunks +20 lines, -20 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-11 20:10:07 UTC) #1
Paul Berry
lgtm
3 years, 11 months ago (2017-01-11 21:35:41 UTC) #2
scheglov
3 years, 11 months ago (2017-01-11 21:37:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9d240f8fb138fda87ffdabd72bf3a25f851444a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698