Add a ref_test key to Anomaly entities and surface it in alerts JSON.

dashboard/dashboard/alerts_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import unittest
 
 import mock
 import webapp2
 import webtest
 
@@ skipping 18 matching lines @@
 
   def _AddAlertsToDataStore(self):
     """Adds sample data, including triaged and non-triaged alerts."""
     key_map = {}
 
     sheriff_key = sheriff.Sheriff(
         id='Chromium Perf Sheriff', email='sullivan@google.com').put()
     testing_common.AddTests(['ChromiumGPU'], ['linux-release'], {
         'scrolling-benchmark': {
             'first_paint': {},
+            'first_paint_ref': {},
             'mean_frame_time': {},
+            'mean_frame_time_ref': {},
         }
     })
     first_paint = utils.TestKey(
         'ChromiumGPU/linux-release/scrolling-benchmark/first_paint')
     mean_frame_time = utils.TestKey(
         'ChromiumGPU/linux-release/scrolling-benchmark/mean_frame_time')
 
     # By default, all TestMetadata entities have an improvement_direction of
     # UNKNOWN, meaning that neither direction is considered an improvement.
     # Here we set the improvement direction so that some anomalies are
     # considered improvements.
     for test_key in [first_paint, mean_frame_time]:
       test = test_key.get()
       test.improvement_direction = anomaly.DOWN
       test.put()
 
     # Add some (12) non-triaged alerts.
     for end_rev in range(10000, 10120, 10):
       test_key = first_paint if end_rev % 20 == 0 else mean_frame_time
+      ref_test_key = utils.TestKey('%s_ref' % utils.TestPath(test_key))
       anomaly_entity = anomaly.Anomaly(
           start_revision=end_rev - 5, end_revision=end_rev, test=test_key,
           median_before_anomaly=100, median_after_anomaly=200,
-          sheriff=sheriff_key)
+          ref_test=ref_test_key, sheriff=sheriff_key)
       anomaly_entity.SetIsImprovement()
       anomaly_key = anomaly_entity.put()
       key_map[end_rev] = anomaly_key.urlsafe()
 
     # Add some (2) already-triaged alerts.
     for end_rev in range(10120, 10140, 10):
       test_key = first_paint if end_rev % 20 == 0 else mean_frame_time
+      ref_test_key = utils.TestKey('%s_ref' % utils.TestPath(test_key))
       bug_id = -1 if end_rev % 20 == 0 else 12345
       anomaly_entity = anomaly.Anomaly(
           start_revision=end_rev - 5, end_revision=end_rev, test=test_key,
           median_before_anomaly=100, median_after_anomaly=200,
-          bug_id=bug_id, sheriff=sheriff_key)
+          ref_test=ref_test_key, bug_id=bug_id, sheriff=sheriff_key)
       anomaly_entity.SetIsImprovement()
       anomaly_key = anomaly_entity.put()
       key_map[end_rev] = anomaly_key.urlsafe()
       if bug_id > 0:
         bug_data.Bug(id=bug_id).put()
 
     # Add some (6) non-triaged improvements.
     for end_rev in range(10140, 10200, 10):
       test_key = mean_frame_time
+      ref_test_key = utils.TestKey('%s_ref' % utils.TestPath(test_key))
       anomaly_entity = anomaly.Anomaly(
           start_revision=end_rev - 5, end_revision=end_rev, test=test_key,
           median_before_anomaly=200, median_after_anomaly=100,
-          sheriff=sheriff_key)
+          ref_test=ref_test_key, sheriff=sheriff_key)
       anomaly_entity.SetIsImprovement()
       anomaly_key = anomaly_entity.put()
       self.assertTrue(anomaly_entity.is_improvement)
       key_map[end_rev] = anomaly_key.urlsafe()
 
     return key_map
 
   def testGet(self):
     response = self.testapp.get('/alerts')
     self.assertEqual('text/html', response.content_type)
@@ skipping 10 matching lines @@
     expected_end_rev = 10110
     for alert in anomaly_list:
       self.assertEqual(expected_end_rev, alert['end_revision'])
       self.assertEqual(expected_end_rev - 5, alert['start_revision'])
       self.assertEqual(key_map[expected_end_rev], alert['key'])
       self.assertEqual('ChromiumGPU', alert['master'])
       self.assertEqual('linux-release', alert['bot'])
       self.assertEqual('scrolling-benchmark', alert['testsuite'])
       if expected_end_rev % 20 == 0:
         self.assertEqual('first_paint', alert['test'])
+        self.assertEqual(
+            'ChromiumGPU/linux-release/scrolling-benchmark/first_paint_ref',
+            alert['ref_test'])
       else:
         self.assertEqual('mean_frame_time', alert['test'])
+        self.assertEqual(
+            'ChromiumGPU/linux-release/scrolling-benchmark/mean_frame_time_ref',
+            alert['ref_test'])
       self.assertEqual('100.0%', alert['percent_changed'])
       self.assertIsNone(alert['bug_id'])
       expected_end_rev -= 10
     self.assertEqual(expected_end_rev, 9990)
 
   def testPost_TriagedParameterSet_TriagedListed(self):
     self._AddAlertsToDataStore()
     response = self.testapp.post('/alerts', {'triaged': 'true'})
     anomaly_list = self.GetJsonValue(response, 'anomaly_list')
     # The alerts listed should contain those added above, including alerts
@@ skipping 75 matching lines @@
   def testPost_ExternalUserRequestsInternalOnlySheriff_ErrorMessage(self):
     sheriff.Sheriff(id='Foo', internal_only=True).put()
     self.assertFalse(utils.IsInternalUser())
     response = self.testapp.post('/alerts?sheriff=Foo')
     error = self.GetJsonValue(response, 'error')
     self.assertIsNotNone(error)
 
 
 if __name__ == '__main__':
   unittest.main()