Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js

Issue 2627073003: [Devtools] Fixed url in Audits and added doctypes (Closed)
Patch Set: fixed audits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js
index 592c1df34a68c921ed8568b78376197a02c6bd39..ce77984d05cc6244ef6a8873d46af91eab4f9af8 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js
@@ -599,7 +599,7 @@ Audits.AuditRules.CacheControlRule = class extends Audits.AuditRule {
var urls = [];
for (var i = 0; i < requestCount; ++i) {
if (requestCheckFunction.call(this, requests[i]))
- urls.push(requests[i].url);
+ urls.push(requests[i].url());
}
if (urls.length) {
var entry = result.addChild(messageText, true);
@@ -743,7 +743,7 @@ Audits.AuditRules.BrowserCacheControlRule = class extends Audits.AuditRules.Cach
true);
result.violationCount += requests.length;
for (var i = 0; i < requests.length; ++i)
- entry.addURL(requests[i].url);
+ entry.addURL(requests[i].url());
}
}
@@ -1330,7 +1330,7 @@ Audits.AuditRules.CookieRuleBase = class extends Audits.AuditRule {
if (!requests)
return;
for (var i = 0; i < requests.length; ++i) {
- if (SDK.Cookies.cookieMatchesResourceURL(cookie, requests[i].url))
+ if (SDK.Cookies.cookieMatchesResourceURL(cookie, requests[i].url()))
callback(requests[i], cookie);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698