WebUI: Remove i18n from cr_elements/network

chrome/browser/resources/chromeos/login/oobe_welcome.js

Index: chrome/browser/resources/chromeos/login/oobe_welcome.js
diff --git a/chrome/browser/resources/chromeos/login/oobe_welcome.js b/chrome/browser/resources/chromeos/login/oobe_welcome.js
index 6384059d2a343e434016b14465755a02ebc6137a..eec1711e1faf07c768faffc2dd21e28fd6a20ca2 100644
--- a/chrome/browser/resources/chromeos/login/oobe_welcome.js
+++ b/chrome/browser/resources/chromeos/login/oobe_welcome.js
@@ -109,6 +109,32 @@ Polymer({
     },
   },
 
+  /** @override */
+  ready: function() {
+    CrOncStrings = {
+      OncTypeCellular: loadTimeData.getString('OncTypeCellular'),
+      OncTypeEthernet: loadTimeData.getString('OncTypeEthernet'),
+      OncTypeVPN: loadTimeData.getString('OncTypeVPN'),
+      OncTypeWiFi: loadTimeData.getString('OncTypeWiFi'),
+      OncTypeWiMAX: loadTimeData.getString('OncTypeWiMAX'),
+      networkDisabled: loadTimeData.getString('networkDisabled'),
+      networkListItemConnected:
+          loadTimeData.getString('networkListItemConnected'),
+      networkListItemConnecting:
+          loadTimeData.getString('networkListItemConnecting'),
+      networkListItemNotConnected:
+          loadTimeData.getString('networkListItemNotConnected'),
+      vpnNameTemplate: loadTimeData.getString('vpnNameTemplate'),
+    };
+    // Additional strings for custom items.
+    CrOncStrings.addMobileNetworkMenuName =
+        loadTimeData.getString('addMobileNetworkMenuName');
+    CrOncStrings.addWiFiNetworkMenuName =
+        loadTimeData.getString('addWiFiNetworkMenuName');
+    CrOncStrings.proxySettingsMenuName =
+        loadTimeData.getString('proxySettingsMenuName');

[Dan Beam, 2017/01/18 02:00:23]

why are you doing this separately from the CrOncStrings = {...} block?

[stevenjb, 2017/01/18 19:49:24]

I thought closure would complain since these are not declared members, but it
doesn't, so changed.

+  },

[Alexander Alekseev, 2017/01/13 22:48:57]

That's sad that these strings have to be initialized in different places
(oobe_welcome.js, settings_ui.js).
Is there a way to check that all the strings used are initialized?

[stevenjb, 2017/01/14 06:11:40]

Well, we could load a shared JS file, but I'm not sure that's really any better.

I've audited the code, and the closure compiler will complain if we try to
directly access a property that isn't defined in CrOncStrings. Other than that,
an error will be thrown if the property doesn't exist, which is really about all
that we can do.

+
   /**
    * Hides all screens to help switching from one screen to another.
    */