WebUI: Remove i18n from cr_elements/network

chrome/browser/resources/chromeos/login/oobe_welcome.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Polymer element for displaying material design OOBE.
  */
 
 Polymer({
   is: 'oobe-welcome-md',
@@ skipping 91 matching lines @@
 
     /**
      * If UI uses forced keyboard navigation.
      */
     highlightStrength: {
       type: String,
       value: '',
     },
   },
 
+  /** @override */
+  ready: function() {
+    CrOncStrings = {
+      OncTypeCellular: loadTimeData.getString('OncTypeCellular'),
+      OncTypeEthernet: loadTimeData.getString('OncTypeEthernet'),
+      OncTypeVPN: loadTimeData.getString('OncTypeVPN'),
+      OncTypeWiFi: loadTimeData.getString('OncTypeWiFi'),
+      OncTypeWiMAX: loadTimeData.getString('OncTypeWiMAX'),
+      networkDisabled: loadTimeData.getString('networkDisabled'),
+      networkListItemConnected:
+          loadTimeData.getString('networkListItemConnected'),
+      networkListItemConnecting:
+          loadTimeData.getString('networkListItemConnecting'),
+      networkListItemNotConnected:
+          loadTimeData.getString('networkListItemNotConnected'),
+      vpnNameTemplate: loadTimeData.getString('vpnNameTemplate'),
+    };
+    // Additional strings for custom items.
+    CrOncStrings.addMobileNetworkMenuName =
+        loadTimeData.getString('addMobileNetworkMenuName');
+    CrOncStrings.addWiFiNetworkMenuName =
+        loadTimeData.getString('addWiFiNetworkMenuName');
+    CrOncStrings.proxySettingsMenuName =
+        loadTimeData.getString('proxySettingsMenuName');

[Dan Beam, 2017/01/18 02:00:23]

why are you doing this separately from the CrOncStrings = {...} block?

[stevenjb, 2017/01/18 19:49:24]

I thought closure would complain since these are not declared members, but it
doesn't, so changed.

+  },

[Alexander Alekseev, 2017/01/13 22:48:57]

That's sad that these strings have to be initialized in different places
(oobe_welcome.js, settings_ui.js).
Is there a way to check that all the strings used are initialized?

[stevenjb, 2017/01/14 06:11:40]

Well, we could load a shared JS file, but I'm not sure that's really any better.

I've audited the code, and the closure compiler will complain if we try to
directly access a property that isn't defined in CrOncStrings. Other than that,
an error will be thrown if the property doesn't exist, which is really about all
that we can do.

+
   /**
    * Hides all screens to help switching from one screen to another.
    */
   hideAllScreens_: function() {
     this.welcomeScreenShown = false;
     this.networkSelectionScreenShown = false;
     this.languageSelectionScreenShown = false;
     this.accessibilityOptionsScreenShown = false;
     this.timezoneScreenShown = false;
   },
@@ skipping 300 matching lines @@
    * @private
    */
   onTimezoneSelected_: function(event) {
     var item = event.detail;
     if (!item)
       return;
 
     this.screen.onTimezoneSelected_(item.value);
   },
 });