Fasta scripts.

Fasta scripts.

R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/685ede6b086dbed7b83fd9213e573247c4f5e67e

[ahe, 2017-01-13 12:40:16]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[ahe, 2017-01-18 10:25:44]

ahe@google.com changed reviewers:
+ karlklose@google.com
- johnniwinther@google.com

[ahe, 2017-01-18 10:25:45]

Karl, could you take a look?

[karlklose, 2017-01-18 12:03:47]

https://codereview.chromium.org/2627023005/diff/1/pkg/fasta/bin/compile.dart
File pkg/fasta/bin/compile.dart (right):

https://codereview.chromium.org/2627023005/diff/1/pkg/fasta/bin/compile.dart#...
pkg/fasta/bin/compile.dart:10: for (int i = 0; i < iterations; i++) {
Consider sharing the code for the environment constant and the loop.

https://codereview.chromium.org/2627023005/diff/1/pkg/fasta/bin/compile.dart#...
pkg/fasta/bin/compile.dart:11: if (iterations > 1 && i > 0) {
Why not just 'i > 0'?

https://codereview.chromium.org/2627023005/diff/1/pkg/fasta/bin/run.dart
File pkg/fasta/bin/run.dart (right):

https://codereview.chromium.org/2627023005/diff/1/pkg/fasta/bin/run.dart#newc...
pkg/fasta/bin/run.dart:47: exit(await run(uri, cl));
Why is the call to run not iterated?

[ahe, 2017-01-18 13:42:36]

Thank you, Karl! PTAL

https://codereview.chromium.org/2627023005/diff/1/pkg/fasta/bin/compile.dart
File pkg/fasta/bin/compile.dart (right):

https://codereview.chromium.org/2627023005/diff/1/pkg/fasta/bin/compile.dart#...
pkg/fasta/bin/compile.dart:10: for (int i = 0; i < iterations; i++) {
On 2017/01/18 12:03:47, karlklose wrote:
> Consider sharing the code for the environment constant and the loop.

We discussed this offline, and you had a great idea I'll try in a follow-up CL.

https://codereview.chromium.org/2627023005/diff/1/pkg/fasta/bin/compile.dart#...
pkg/fasta/bin/compile.dart:11: if (iterations > 1 && i > 0) {
On 2017/01/18 12:03:47, karlklose wrote:
> Why not just 'i > 0'?

Brain fart.

https://codereview.chromium.org/2627023005/diff/1/pkg/fasta/bin/run.dart
File pkg/fasta/bin/run.dart (right):

https://codereview.chromium.org/2627023005/diff/1/pkg/fasta/bin/run.dart#newc...
pkg/fasta/bin/run.dart:47: exit(await run(uri, cl));
On 2017/01/18 12:03:47, karlklose wrote:
> Why is the call to run not iterated?

I didn't find it useful for profiling.

[karlklose, 2017-01-18 13:43:48]

LGTM

[ahe, 2017-01-18 13:56:39]

Description was changed from

==========
Fasta scripts.
==========

to

==========
Fasta scripts.

R=karlklose@google.com

Committed:
https://github.com/dart-lang/sdk/commit/685ede6b086dbed7b83fd9213e573247c4f5e67e
==========

[ahe, 2017-01-18 13:56:40]

Committed patchset #2 (id:20001) manually as
685ede6b086dbed7b83fd9213e573247c4f5e67e (presubmit successful).