Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: content/browser/service_worker/service_worker_fetch_dispatcher.cc

Issue 2627023002: Introduce Origin-Trial for Service Worker Navigation Preload (Closed)
Patch Set: s/an/a Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_fetch_dispatcher.cc
diff --git a/content/browser/service_worker/service_worker_fetch_dispatcher.cc b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
index c71cfb4e045e62bb44e1fa759da184b5ad98a024..122e931126b87a35c1a1abb0efe573ce203d995c 100644
--- a/content/browser/service_worker/service_worker_fetch_dispatcher.cc
+++ b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
@@ -8,7 +8,6 @@
#include <utility>
#include "base/bind.h"
-#include "base/feature_list.h"
#include "base/memory/ptr_util.h"
#include "base/time/time.h"
#include "base/trace_event/trace_event.h"
@@ -25,7 +24,6 @@
#include "content/common/service_worker/service_worker_types.h"
#include "content/common/service_worker/service_worker_utils.h"
#include "content/public/common/browser_side_navigation_policy.h"
-#include "content/public/common/content_features.h"
#include "mojo/public/cpp/bindings/associated_binding.h"
#include "mojo/public/cpp/bindings/binding.h"
#include "net/http/http_util.h"
@@ -400,10 +398,11 @@ void ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload(
// TODO(horo): Currently NavigationPreload doesn't support request body.
if (!request_->blob_uuid.empty())
return;
- if (!base::FeatureList::IsEnabled(
- features::kServiceWorkerNavigationPreload)) {
- // TODO(horo): Check |version_|'s origin_trial_tokens() here if we use
- // Origin-Trial for NavigationPreload.
+
+ ServiceWorkerVersion::NavigationPreloadSupportStatus support_status =
+ version_->GetNavigationPreloadSupportStatus();
+ if (support_status !=
+ ServiceWorkerVersion::NavigationPreloadSupportStatus::SUPPORTED) {
return;
}

Powered by Google App Engine
This is Rietveld 408576698