Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/objects-inl.h

Issue 2627003005: [printing] Remove duplicate code that prints property details. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 3120 matching lines...) Expand 10 before | Expand all | Expand 10 after
3131 PropertyType DescriptorArray::GetType(int descriptor_number) { 3131 PropertyType DescriptorArray::GetType(int descriptor_number) {
3132 return GetDetails(descriptor_number).type(); 3132 return GetDetails(descriptor_number).type();
3133 } 3133 }
3134 3134
3135 3135
3136 int DescriptorArray::GetFieldIndex(int descriptor_number) { 3136 int DescriptorArray::GetFieldIndex(int descriptor_number) {
3137 DCHECK(GetDetails(descriptor_number).location() == kField); 3137 DCHECK(GetDetails(descriptor_number).location() == kField);
3138 return GetDetails(descriptor_number).field_index(); 3138 return GetDetails(descriptor_number).field_index();
3139 } 3139 }
3140 3140
3141 FieldType* DescriptorArray::GetFieldType(int descriptor_number) {
3142 DCHECK(GetDetails(descriptor_number).location() == kField);
3143 Object* wrapped_type = GetValue(descriptor_number);
3144 return Map::UnwrapFieldType(wrapped_type);
3145 }
3146
3141 Object* DescriptorArray::GetConstant(int descriptor_number) { 3147 Object* DescriptorArray::GetConstant(int descriptor_number) {
3142 return GetValue(descriptor_number); 3148 return GetValue(descriptor_number);
3143 } 3149 }
3144 3150
3145 3151
3146 Object* DescriptorArray::GetCallbacksObject(int descriptor_number) { 3152 Object* DescriptorArray::GetCallbacksObject(int descriptor_number) {
3147 DCHECK(GetType(descriptor_number) == ACCESSOR_CONSTANT); 3153 DCHECK(GetType(descriptor_number) == ACCESSOR_CONSTANT);
3148 return GetValue(descriptor_number); 3154 return GetValue(descriptor_number);
3149 } 3155 }
3150 3156
(...skipping 5297 matching lines...) Expand 10 before | Expand all | Expand 10 after
8448 #undef WRITE_INT64_FIELD 8454 #undef WRITE_INT64_FIELD
8449 #undef READ_BYTE_FIELD 8455 #undef READ_BYTE_FIELD
8450 #undef WRITE_BYTE_FIELD 8456 #undef WRITE_BYTE_FIELD
8451 #undef NOBARRIER_READ_BYTE_FIELD 8457 #undef NOBARRIER_READ_BYTE_FIELD
8452 #undef NOBARRIER_WRITE_BYTE_FIELD 8458 #undef NOBARRIER_WRITE_BYTE_FIELD
8453 8459
8454 } // namespace internal 8460 } // namespace internal
8455 } // namespace v8 8461 } // namespace v8
8456 8462
8457 #endif // V8_OBJECTS_INL_H_ 8463 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/objects-printer.cc » ('j') | src/property.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698