Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 26270004: Element should not use confusingAndOftenMisusedAttached (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.h
diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h
index 938dd87e15b8237a25fb2f128f4d582763564ee3..fc4c1f97b6535e7cee88229a51ca0bef570004a5 100644
--- a/Source/core/html/HTMLMediaElement.h
+++ b/Source/core/html/HTMLMediaElement.h
@@ -96,7 +96,7 @@ public:
};
void scheduleDelayedAction(DelayedActionType);
- bool inActiveDocument() const { return m_inActiveDocument; }
+ bool isActive() const { return m_active; }
// DOM API
// error state
@@ -514,10 +514,11 @@ private:
typedef unsigned PendingActionFlags;
PendingActionFlags m_pendingActionFlags;
+ // FIXME: MediaElement has way too many state bits.
bool m_playing : 1;
bool m_shouldDelayLoadEvent : 1;
bool m_haveFiredLoadedData : 1;
- bool m_inActiveDocument : 1;
+ bool m_active : 1;
bool m_autoplaying : 1;
bool m_muted : 1;
bool m_paused : 1;
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698