Element should not use confusingAndOftenMisusedAttached

Source/core/html/HTMLMediaElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 254 matching lines @@
     , m_displayMode(Unknown)
     , m_cachedTime(MediaPlayer::invalidTime())
     , m_cachedTimeWallClockUpdateTime(0)
     , m_minimumWallClockTimeToCacheMediaTime(0)
     , m_fragmentStartTime(MediaPlayer::invalidTime())
     , m_fragmentEndTime(MediaPlayer::invalidTime())
     , m_pendingActionFlags(0)
     , m_playing(false)
     , m_shouldDelayLoadEvent(false)
     , m_haveFiredLoadedData(false)
-    , m_inActiveDocument(true)
+    , m_active(true)
     , m_autoplaying(true)
     , m_muted(false)
     , m_paused(true)
     , m_seeking(false)
     , m_sentStalledEvent(false)
     , m_sentEndEvent(false)
     , m_pausedInternal(false)
     , m_sendProgressEvents(true)
     , m_closedCaptionsVisible(false)
     , m_loadInitiatedByUserGesture(false)
@@ skipping 193 matching lines @@
 {
     return hasMediaControls() && HTMLElement::childShouldCreateRenderer(child);
 }
 
 Node::InsertionNotificationRequest HTMLMediaElement::insertedInto(ContainerNode* insertionPoint)
 {
     LOG(Media, "HTMLMediaElement::insertedInto");
 
     HTMLElement::insertedInto(insertionPoint);
     if (insertionPoint->inDocument()) {
-        m_inActiveDocument = true;
+        m_active = true;
 
         if (!getAttribute(srcAttr).isEmpty() && m_networkState == NETWORK_EMPTY)
             scheduleDelayedAction(LoadMediaResource);
     }
 
     configureMediaControls();
     return InsertionDone;
 }
 
 void HTMLMediaElement::removedFrom(ContainerNode* insertionPoint)
 {
     LOG(Media, "HTMLMediaElement::removedFrom");
 
-    m_inActiveDocument = false;
+    m_active = false;
     if (insertionPoint->inDocument()) {
         configureMediaControls();
         if (m_networkState > NETWORK_EMPTY)
             pause();
     }
 
     HTMLElement::removedFrom(insertionPoint);
 }
 
 void HTMLMediaElement::attach(const AttachContext& context)
@@ skipping 703 matching lines @@
 
 void HTMLMediaElement::beginIgnoringTrackDisplayUpdateRequests()
 {
     ++m_ignoreTrackDisplayUpdate;
 }
 
 void HTMLMediaElement::endIgnoringTrackDisplayUpdateRequests()
 {
     ASSERT(m_ignoreTrackDisplayUpdate);
     --m_ignoreTrackDisplayUpdate;
-    if (!m_ignoreTrackDisplayUpdate && m_inActiveDocument)
+    if (!m_ignoreTrackDisplayUpdate && m_active)
         updateActiveTextTrackCues(currentTime());
 }
 
 void HTMLMediaElement::textTrackAddCues(TextTrack* track, const TextTrackCueList* cues)
 {
     LOG(Media, "HTMLMediaElement::textTrackAddCues");
     if (track->mode() == TextTrack::disabledKeyword())
         return;
 
     TrackDisplayUpdateScope scope(this);
@@ skipping 2166 matching lines @@
     m_loadState = WaitingForSource;
 
     if (m_textTracks)
         configureTextTrackDisplay(AssumeNoVisibleChange);
 }
 
 void HTMLMediaElement::stop()
 {
     LOG(Media, "HTMLMediaElement::stop");
 
-    m_inActiveDocument = false;
+    m_active = false;
     userCancelledLoad();
 
     // Stop the playback without generating events
     m_playing = false;
     setPausedInternal(true);
 
     if (renderer())
         renderer()->updateFromElement();
 
     stopPeriodicTimers();
@@ skipping 445 matching lines @@
 {
     scheduleLayerUpdate();
 }
 
 bool HTMLMediaElement::isInteractiveContent() const
 {
     return fastHasAttribute(controlsAttr);
 }
 
 }