components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h - Issue 2626963003: Remove kAllowed and kFallbackAllowed from data reduction proxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h

Issue 2626963003: Remove kAllowed and kFallbackAllowed from data reduction proxy (Closed)

Patch Set: Addressed nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc ('k') | components/data_reduction_proxy/core/common/data_reduction_proxy_params.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h

diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h b/components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h

index 28bc3f004b7953ccbfa3274f5934ace7913ebefd..15c4579228837fab46fffa3e80c84885ab4b3b71 100644

--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h

+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h

@@ -26,12 +26,6 @@ class DataReductionProxyConfigValues {

// proxy if enabled.

virtual bool holdback() const = 0;

- // Returns true if the data reduction proxy configuration may be used.

- virtual bool allowed() const = 0;

- // Returns true if the fallback proxy may be used.

- virtual bool fallback_allowed() const = 0;

// Returns the HTTP proxy servers to be used.

virtual const std::vector<DataReductionProxyServer> proxies_for_http()

const = 0;