Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

Issue 2626963003: Remove kAllowed and kFallbackAllowed from data reduction proxy (Closed)
Patch Set: Addressed nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
index f5225420d8a8600693d6e21e8890f6df2b241bba..a258151356bc690b7d9fe9d5ce28441f3b53fa26 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
@@ -187,11 +187,6 @@ class DataReductionProxySettings : public DataReductionProxyServiceObserver,
// InitDataReductionProxySettings has not been called.
DataReductionProxyEventStore* GetEventStore() const;
- // Returns true if the data reduction proxy configuration may be used.
- bool Allowed() const {
- return allowed_;
- }
-
// Returns true if the data reduction proxy promo may be shown.
// This is independent of whether the data reduction proxy is allowed.
bool PromoAllowed() const {
@@ -224,12 +219,12 @@ class DataReductionProxySettings : public DataReductionProxyServiceObserver,
// Metrics method. Subclasses should override if they wish to provide
// alternatives.
- virtual void RecordDataReductionInit();
+ virtual void RecordDataReductionInit() const;
// Virtualized for mocking. Records UMA specifying whether the proxy was
// enabled or disabled at startup.
virtual void RecordStartupState(
- data_reduction_proxy::ProxyStartupState state);
+ data_reduction_proxy::ProxyStartupState state) const;
private:
friend class DataReductionProxySettingsTestBase;

Powered by Google App Engine
This is Rietveld 408576698