chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc - Issue 2626963003: Remove kAllowed and kFallbackAllowed from data reduction proxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

Issue 2626963003: Remove kAllowed and kFallbackAllowed from data reduction proxy (Closed)

Patch Set: Addressed nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc ('k') | chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc b/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

index 3495ebe42a296b012ea8d0fd0938ad85b0e52a38..c4928f0cf69a6d9e7e4483e3db11239938c39d12 100644

--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

@@ -62,15 +62,9 @@ class TestDataReductionProxySettingsAndroid

template <class C>

void data_reduction_proxy::DataReductionProxySettingsTestBase::ResetSettings(

std::unique_ptr<base::Clock> clock,

- bool allowed,

- bool fallback_allowed,

bool promo_allowed,

bool holdback) {

int flags = 0;

- if (allowed)

- flags |= DataReductionProxyParams::kAllowed;

- if (fallback_allowed)

- flags |= DataReductionProxyParams::kFallbackAllowed;

if (promo_allowed)

flags |= DataReductionProxyParams::kPromoAllowed;

if (holdback)

@@ -94,8 +88,6 @@ void data_reduction_proxy::DataReductionProxySettingsTestBase::ResetSettings(

template void

data_reduction_proxy::DataReductionProxySettingsTestBase::ResetSettings<

DataReductionProxyChromeSettings>(std::unique_ptr<base::Clock> clock,

- bool allowed,

- bool fallback_allowed,

bool promo_allowed,

bool holdback);