Issue 26269002: Initial draft code to run pdfviewer withg gms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26269002: Initial draft code to run pdfviewer withg gms (Closed)

Created:
7 years, 2 months ago by edisonn

Modified:
7 years, 1 month ago

Reviewers:
scroggo, borenet

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Initial draft code to run pdfviewer withg gms draft cl to run pdfviewer with gms modified: gm/gmmain.cpp modified: gyp/gm.gyp modified: src/utils/SkPDFRasterizer.cpp modified: src/utils/SkPDFRasterizer.h Committed: http://code.google.com/p/skia/source/detail?r=12214

Patch Set 1 #

Patch Set 2 : use the macro #

Patch Set 3 : add variable to be enabled only in one bot #

Patch Set 4 : use a variable instead of commenting the dsefine, so we can enable it on a buildbot #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
M	gm/gmmain.cpp	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	gyp/common_variables.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/gm.gyp	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/utils/SkPDFRasterizer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/utils/SkPDFRasterizer.cpp	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

edisonn

added a condition that enables it on a buildbot - related https://codereview.chromium.org/64113004/

7 years, 1 month ago (2013-11-07 22:16:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/edisonn@google.com/26269002/25003

7 years, 1 month ago (2013-11-11 14:54:17 UTC) #5

Message was sent while issue was closed.

Change committed as 12214

Expand Messages | Collapse Messages