Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 26269002: Initial draft code to run pdfviewer withg gms (Closed)

Created:
7 years, 2 months ago by edisonn
Modified:
7 years, 1 month ago
Reviewers:
scroggo, borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Initial draft code to run pdfviewer withg gms draft cl to run pdfviewer with gms modified: gm/gmmain.cpp modified: gyp/gm.gyp modified: src/utils/SkPDFRasterizer.cpp modified: src/utils/SkPDFRasterizer.h Committed: http://code.google.com/p/skia/source/detail?r=12214

Patch Set 1 #

Patch Set 2 : use the macro #

Patch Set 3 : add variable to be enabled only in one bot #

Patch Set 4 : use a variable instead of commenting the dsefine, so we can enable it on a buildbot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M gm/gmmain.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M gyp/common_variables.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gyp/gm.gyp View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M src/utils/SkPDFRasterizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/utils/SkPDFRasterizer.cpp View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
edisonn
7 years, 1 month ago (2013-11-07 21:28:22 UTC) #1
scroggo
lgtm
7 years, 1 month ago (2013-11-07 21:45:04 UTC) #2
edisonn
added a condition that enables it on a buildbot - related https://codereview.chromium.org/64113004/
7 years, 1 month ago (2013-11-07 22:16:04 UTC) #3
borenet
GYP change LGTM
7 years, 1 month ago (2013-11-08 13:55:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/edisonn@google.com/26269002/25003
7 years, 1 month ago (2013-11-11 14:54:17 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-11 15:10:51 UTC) #6
Message was sent while issue was closed.
Change committed as 12214

Powered by Google App Engine
This is Rietveld 408576698