Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1537)

Unified Diff: chrome/browser/permissions/permission_blacklist_client.cc

Issue 2626853002: Refactor blacklist client into own .h/.cc. (Closed)
Patch Set: Nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_blacklist_client.cc
diff --git a/chrome/browser/permissions/permission_blacklist_client.cc b/chrome/browser/permissions/permission_blacklist_client.cc
new file mode 100644
index 0000000000000000000000000000000000000000..18f57460283852ab4b0b7b384a71d91ed39d8d1d
--- /dev/null
+++ b/chrome/browser/permissions/permission_blacklist_client.cc
@@ -0,0 +1,102 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/permissions/permission_blacklist_client.h"
+
+#include <set>
+#include <string>
+
+#include "base/logging.h"
+#include "base/memory/ptr_util.h"
+#include "base/timer/timer.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/web_contents.h"
+#include "url/gurl.h"
+
+// static
+void PermissionBlacklistClient::CheckSafeBrowsingBlacklist(
+ scoped_refptr<safe_browsing::SafeBrowsingDatabaseManager> db_manager,
+ content::PermissionType permission_type,
+ const GURL& request_origin,
+ content::WebContents* web_contents,
+ int timeout,
+ base::Callback<void(bool)> callback) {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+ new PermissionBlacklistClient(db_manager, permission_type, request_origin,
+ web_contents, timeout, callback);
+}
+
+PermissionBlacklistClient::PermissionBlacklistClient(
+ scoped_refptr<safe_browsing::SafeBrowsingDatabaseManager> db_manager,
+ content::PermissionType permission_type,
+ const GURL& request_origin,
+ content::WebContents* web_contents,
+ int timeout,
+ base::Callback<void(bool)> callback)
+ : content::WebContentsObserver(web_contents),
+ db_manager_(db_manager),
+ permission_type_(permission_type),
+ callback_(callback),
+ timeout_(timeout),
+ is_active_(true) {
+ // Balanced by a call to Release() in OnCheckApiBlacklistUrlResult().
+ AddRef();
+ content::BrowserThread::PostTask(
+ content::BrowserThread::IO, FROM_HERE,
+ base::Bind(&PermissionBlacklistClient::StartCheck, this, request_origin));
+}
+
+PermissionBlacklistClient::~PermissionBlacklistClient() {}
+
+void PermissionBlacklistClient::StartCheck(const GURL& request_origin) {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+
+ // Start the timer to interrupt into the client callback method with an
+ // empty response if Safe Browsing times out.
+ safe_browsing::ThreatMetadata empty_metadata;
+ timer_ = base::MakeUnique<base::OneShotTimer>();
+ timer_->Start(
+ FROM_HERE, base::TimeDelta::FromMilliseconds(timeout_),
+ base::Bind(&PermissionBlacklistClient::OnCheckApiBlacklistUrlResult, this,
+ request_origin, empty_metadata));
+ db_manager_->CheckApiBlacklistUrl(request_origin, this);
+}
+
+void PermissionBlacklistClient::OnCheckApiBlacklistUrlResult(
+ const GURL& url,
+ const safe_browsing::ThreatMetadata& metadata) {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+
+ if (timer_->IsRunning())
+ timer_->Stop();
+ else
+ db_manager_->CancelApiCheck(this);
+ timer_.reset(nullptr);
+
+ // TODO(meredithl): Convert the strings returned from Safe Browsing to the
+ // ones used by PermissionUtil for comparison.
+ bool permission_blocked =
+ metadata.api_permissions.find(PermissionUtil::GetPermissionString(
+ permission_type_)) != metadata.api_permissions.end();
+
+ content::BrowserThread::PostTask(
+ content::BrowserThread::UI, FROM_HERE,
+ base::Bind(&PermissionBlacklistClient::EvaluateBlacklistResultOnUiThread,
+ this, permission_blocked));
+}
+
+void PermissionBlacklistClient::EvaluateBlacklistResultOnUiThread(
+ bool permission_blocked) {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+ if (is_active_)
+ callback_.Run(permission_blocked);
+ Release();
+}
+
+void PermissionBlacklistClient::WebContentsDestroyed() {
+ is_active_ = false;
+ Observe(nullptr);
+}
« no previous file with comments | « chrome/browser/permissions/permission_blacklist_client.h ('k') | chrome/browser/permissions/permission_context_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698