Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2626843003: Implement 'covariant' modifier for dart2js. (Closed)

Created:
3 years, 11 months ago by floitsch
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, hausner, Brian Wilkerson
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement 'covariant' modifier for dart2js. Also adds some tests. Fixes #28165 BUG= http://dartbug.com/28165 R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/71ec2f0297baf49cc4c3dd61bfaefb3d229b8f6b

Patch Set 1 #

Patch Set 2 : Slightly change comment. #

Total comments: 4

Patch Set 3 : Fix bad "continued" lines. #

Patch Set 4 : Update status file for dartk. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+522 lines, -1 line) Patch
M pkg/compiler/lib/src/parser/parser.dart View 1 2 chunks +29 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tokens/keyword.dart View 2 chunks +2 lines, -1 line 0 comments Download
A tests/language/covariant_override_test.dart View 1 chunk +92 lines, -0 lines 0 comments Download
A tests/language/covariant_test.dart View 1 2 1 chunk +378 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +11 lines, -0 lines 0 comments Download
M tests/language/language_kernel.status View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
floitsch
3 years, 11 months ago (2017-01-11 15:07:40 UTC) #2
eernst
DBC, couple of possible typos. https://codereview.chromium.org/2626843003/diff/20001/tests/language/covariant_test.dart File tests/language/covariant_test.dart (right): https://codereview.chromium.org/2626843003/diff/20001/tests/language/covariant_test.dart#newcode342 tests/language/covariant_test.dart:342: A.x26 = 0; /// ...
3 years, 11 months ago (2017-01-11 16:20:08 UTC) #4
floitsch
Thanks. Good catches. https://codereview.chromium.org/2626843003/diff/20001/tests/language/covariant_test.dart File tests/language/covariant_test.dart (right): https://codereview.chromium.org/2626843003/diff/20001/tests/language/covariant_test.dart#newcode342 tests/language/covariant_test.dart:342: A.x26 = 0; /// 06: continued ...
3 years, 11 months ago (2017-01-11 18:02:33 UTC) #5
Siggi Cherem (dart-lang)
lgtm. Thanks Florian!
3 years, 11 months ago (2017-01-11 18:11:42 UTC) #6
floitsch
3 years, 11 months ago (2017-01-11 18:12:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
71ec2f0297baf49cc4c3dd61bfaefb3d229b8f6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698