Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 262683003: Add CrOS event rewriters to the Ozone build (Closed)

Created:
6 years, 7 months ago by dnicoara
Modified:
6 years, 7 months ago
Reviewers:
Daniel Erat, kpschoedel
CC:
chromium-reviews
Visibility:
Public.

Description

Add CrOS event rewriters to the Ozone build This fixes the CrOS build under Ozone. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267277

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/chrome_browser_chromeos.gypi View 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
dnicoara
derat@ for OWNERS kpschoedel@ FYI This CL enables these the rewriters in https://codereview.chromium.org/240173007
6 years, 7 months ago (2014-04-30 18:05:05 UTC) #1
Daniel Erat
lgtm as a quick fix with one question https://codereview.chromium.org/262683003/diff/1/chrome/chrome_browser_chromeos.gypi File chrome/chrome_browser_chromeos.gypi (right): https://codereview.chromium.org/262683003/diff/1/chrome/chrome_browser_chromeos.gypi#newcode1087 chrome/chrome_browser_chromeos.gypi:1087: ['include', ...
6 years, 7 months ago (2014-04-30 18:12:07 UTC) #2
kpschoedel
https://codereview.chromium.org/262683003/diff/1/chrome/chrome_browser_chromeos.gypi File chrome/chrome_browser_chromeos.gypi (right): https://codereview.chromium.org/262683003/diff/1/chrome/chrome_browser_chromeos.gypi#newcode1087 chrome/chrome_browser_chromeos.gypi:1087: ['include', '^browser/chromeos/events/keyboard_driven_event_rewriter.h'], The X11 dependencies are being isolated and/or ...
6 years, 7 months ago (2014-04-30 18:23:31 UTC) #3
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 7 months ago (2014-04-30 18:25:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/262683003/1
6 years, 7 months ago (2014-04-30 18:26:50 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 18:29:24 UTC) #6
Message was sent while issue was closed.
Change committed as 267277

Powered by Google App Engine
This is Rietveld 408576698