Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 2626823008: [sql] Move time-machine support from third_party/sqlite to sql/ (Closed)

Created:
3 years, 11 months ago by Scott Hess - ex-Googler
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, mac-reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Move time-machine support from third_party/sqlite to sql/ NCI, testing the failure case. Chromium's SQLite was modified to propagate OSX Time-Machine exclusions from the main database file to any associated journal files. Re-implement this using a VFS which wraps the default VFS and makes the check when opening journal files. BUG=679941

Patch Set 1 #

Patch Set 2 : deeper #

Patch Set 3 : use setxattr instead. #

Patch Set 4 : git cl try #

Patch Set 5 : wrapper users base::mac:: setter #

Patch Set 6 : CSBackupDebugLogging #

Patch Set 7 : drop excess calls #

Patch Set 8 : early set on preference #

Patch Set 9 : debugging code #

Patch Set 10 : stat log #

Patch Set 11 : ps output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+754 lines, -253 lines) Patch
M base/mac/mac_util.mm View 1 2 3 4 5 6 7 8 9 4 chunks +147 lines, -0 lines 0 comments Download
M sql/BUILD.gn View 2 chunks +10 lines, -0 lines 0 comments Download
M sql/connection.cc View 1 2 3 4 5 6 7 4 chunks +24 lines, -1 line 0 comments Download
M sql/sqlite_features_unittest.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +94 lines, -0 lines 0 comments Download
A sql/vfs_wrapper.h View 1 chunk +23 lines, -0 lines 0 comments Download
A sql/vfs_wrapper.cc View 1 2 3 4 1 chunk +449 lines, -0 lines 0 comments Download
M third_party/sqlite/amalgamation/sqlite3.c View 6 chunks +3 lines, -45 lines 0 comments Download
D third_party/sqlite/patches/0003-Exclude-journal-file-from-Time-Machine-if-database-i.patch View 1 chunk +0 lines, -157 lines 0 comments Download
M third_party/sqlite/src/Makefile.linux-gcc View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/sqlite/src/ext/fts3/fts3_porter.c View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/sqlite/src/main.mk View 1 chunk +1 line, -1 line 0 comments Download
M third_party/sqlite/src/src/pager.c View 2 chunks +0 lines, -32 lines 0 comments Download
M third_party/sqlite/src/src/sqliteInt.h View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 37 (29 generated)
Scott Hess - ex-Googler
deeper
3 years, 11 months ago (2017-01-13 01:19:25 UTC) #5
Scott Hess - ex-Googler
use setxattr instead.
3 years, 11 months ago (2017-01-13 04:57:43 UTC) #10
Scott Hess - ex-Googler
wrapper users base::mac:: setter
3 years, 11 months ago (2017-01-13 10:52:11 UTC) #19
Scott Hess - ex-Googler
CSBackupDebugLogging
3 years, 11 months ago (2017-01-17 22:02:41 UTC) #24
Scott Hess - ex-Googler
drop excess calls
3 years, 11 months ago (2017-01-17 23:25:28 UTC) #27
Scott Hess - ex-Googler
early set on preference
3 years, 11 months ago (2017-01-17 23:58:39 UTC) #30
Scott Hess - ex-Googler
debugging code
3 years, 11 months ago (2017-01-18 21:31:05 UTC) #35
Scott Hess - ex-Googler
3 years, 11 months ago (2017-01-18 23:25:07 UTC) #36
stat log

Powered by Google App Engine
This is Rietveld 408576698