Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: headless/lib/browser/headless_devtools_manager_delegate.h

Issue 2626823003: [headless] Add default browser context to HeadlessBrowser. (Closed)
Patch Set: More explicit error message. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/lib/browser/headless_devtools_manager_delegate.h
diff --git a/headless/lib/browser/headless_devtools_manager_delegate.h b/headless/lib/browser/headless_devtools_manager_delegate.h
index 3b800d53c1aa62abae4f19e37972064f37cd7a61..c891e8246c6cde5d7b45b26e27cd60e27d502015 100644
--- a/headless/lib/browser/headless_devtools_manager_delegate.h
+++ b/headless/lib/browser/headless_devtools_manager_delegate.h
@@ -16,7 +16,6 @@
namespace headless {
class HeadlessBrowserImpl;
-class HeadlessBrowserContext;
class HeadlessDevToolsManagerDelegate
: public content::DevToolsManagerDelegate {
@@ -32,22 +31,26 @@ class HeadlessDevToolsManagerDelegate
std::string GetFrontendResource(const std::string& path) override;
private:
- std::unique_ptr<base::Value> CreateTarget(
+ std::unique_ptr<base::DictionaryValue> CreateTarget(
+ int command_id,
const base::DictionaryValue* params);
- std::unique_ptr<base::Value> CloseTarget(const base::DictionaryValue* params);
- std::unique_ptr<base::Value> CreateBrowserContext(
+ std::unique_ptr<base::DictionaryValue> CloseTarget(
+ int command_id,
const base::DictionaryValue* params);
- std::unique_ptr<base::Value> DisposeBrowserContext(
+ std::unique_ptr<base::DictionaryValue> CreateBrowserContext(
+ int command_id,
+ const base::DictionaryValue* params);
+ std::unique_ptr<base::DictionaryValue> DisposeBrowserContext(
+ int command_id,
const base::DictionaryValue* params);
base::WeakPtr<HeadlessBrowserImpl> browser_;
- using CommandMemberFnPtr = std::unique_ptr<base::Value> (
- HeadlessDevToolsManagerDelegate::*)(const base::DictionaryValue* params);
+ using CommandMemberFnPtr = std::unique_ptr<base::DictionaryValue> (
+ HeadlessDevToolsManagerDelegate::*)(int command_id,
+ const base::DictionaryValue* params);
std::map<std::string, CommandMemberFnPtr> command_map_;
-
- HeadlessBrowserContext* default_browser_context_;
};
} // namespace headless
« no previous file with comments | « headless/lib/browser/headless_browser_impl.cc ('k') | headless/lib/browser/headless_devtools_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698