Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2229)

Unified Diff: src/core/SkBitmap.cpp

Issue 26268003: Always clear dest in SkBitmap::copyTo's draw path (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkBitmap.cpp
===================================================================
--- src/core/SkBitmap.cpp (revision 11695)
+++ src/core/SkBitmap.cpp (working copy)
@@ -1119,10 +1119,8 @@
}
}
} else {
- // if the src has alpha, we have to clear the dst first
- if (!src->isOpaque()) {
- tmpDst.eraseColor(SK_ColorTRANSPARENT);
- }
+ // Always clear the dest in case one of the blitters accesses it
+ tmpDst.eraseColor(SK_ColorTRANSPARENT);
reed1 2013/10/10 15:16:38 // TODO: switch the allocation of tmpDst to call s
robertphillips 2013/10/10 15:48:34 Done.
SkCanvas canvas(tmpDst);
SkPaint paint;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698