Issue 26268003: Always clear dest in SkBitmap::copyTo's draw path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26268003: Always clear dest in SkBitmap::copyTo's draw path (Closed)

Created:
7 years, 2 months ago by robertphillips

Modified:
7 years, 2 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Some blitters still access the dest even though the src is truly opaque. To address this we now always clear the destination in SkBitmap::copyTo's draw path.

Patch Set 1 #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	src/core/SkBitmap.cpp	View		1 chunk	+2 lines, -4 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

reed1

lgtm https://codereview.chromium.org/26268003/diff/1/src/core/SkBitmap.cpp File src/core/SkBitmap.cpp (right): https://codereview.chromium.org/26268003/diff/1/src/core/SkBitmap.cpp#newcode1123 src/core/SkBitmap.cpp:1123: tmpDst.eraseColor(SK_ColorTRANSPARENT); // TODO: switch the allocation of tmpDst ...

7 years, 2 months ago (2013-10-10 15:16:38 UTC) #2

robertphillips

7 years, 2 months ago (2013-10-10 15:48:33 UTC) #3

Message was sent while issue was closed.

committed as r11697

https://codereview.chromium.org/26268003/diff/1/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

https://codereview.chromium.org/26268003/diff/1/src/core/SkBitmap.cpp#newcode...
src/core/SkBitmap.cpp:1123: tmpDst.eraseColor(SK_ColorTRANSPARENT);
On 2013/10/10 15:16:38, reed1 wrote:
> // TODO: switch the allocation of tmpDst to call sk_calloc_throw

Done.

Expand Messages | Collapse Messages