Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 26268002: Emit assets in serial, use Stream.pipe to write to output files (Closed)

Created:
7 years, 2 months ago by kevmoo-old
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : another forEach #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M pkg/polymer/lib/src/build/runner.dart View 1 4 chunks +14 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kevmoo-old
I replaced the usage of Future.wait w/ a Future.forEach This ensures that we don't get ...
7 years, 2 months ago (2013-10-07 15:18:06 UTC) #1
Siggi Cherem (dart-lang)
lgtm with comment below? https://codereview.chromium.org/26268002/diff/1/pkg/polymer/lib/src/build/runner.dart File pkg/polymer/lib/src/build/runner.dart (right): https://codereview.chromium.org/26268002/diff/1/pkg/polymer/lib/src/build/runner.dart#newcode283 pkg/polymer/lib/src/build/runner.dart:283: return Future.wait(futures); change here also ...
7 years, 2 months ago (2013-10-07 16:29:35 UTC) #2
kevmoo-old
https://codereview.chromium.org/26268002/diff/1/pkg/polymer/lib/src/build/runner.dart File pkg/polymer/lib/src/build/runner.dart (right): https://codereview.chromium.org/26268002/diff/1/pkg/polymer/lib/src/build/runner.dart#newcode283 pkg/polymer/lib/src/build/runner.dart:283: return Future.wait(futures); On 2013/10/07 16:29:35, Siggi Cherem (dart-lang) wrote: ...
7 years, 2 months ago (2013-10-07 17:08:04 UTC) #3
kevmoo-old
Committed patchset #2 manually as r28314 (presubmit successful).
7 years, 2 months ago (2013-10-07 17:08:41 UTC) #4
Jennifer Messerly
On 2013/10/07 17:08:41, kevmoo wrote: > Committed patchset #2 manually as r28314 (presubmit successful). Can ...
7 years, 2 months ago (2013-10-07 18:04:32 UTC) #5
Siggi Cherem (dart-lang)
7 years, 2 months ago (2013-10-07 18:31:50 UTC) #6
Message was sent while issue was closed.
On 2013/10/07 18:04:32, John Messerly wrote:
> On 2013/10/07 17:08:41, kevmoo wrote:
> > Committed patchset #2 manually as r28314 (presubmit successful).
> 
> Can we add a comment about why we are doing async IO but serializing all the
> operations?

oops, forgot to mention that, yes +1. I think for asset makes sense because all
the 'read' APIs are async in the first place. For copy we should either switch
to a sync API or mention this is either because we hope this will be fixed in
dart:io.

Powered by Google App Engine
This is Rietveld 408576698