Issue 2626753002: VM: Add missing token position in async rethrow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2626753002: VM: Add missing token position in async rethrow (Closed)

Created:
3 years, 11 months ago by Florian Schneider

Modified:
3 years, 11 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -2 lines)			Patch
M	runtime/vm/ast_transformer.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/language/language_kernel.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/vm/regress_28325_test.dart	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

hausner

LGTM. The test is a bit fragile but at least it is small so it ...

3 years, 11 months ago (2017-01-10 21:42:39 UTC) #3

Florian Schneider

3 years, 11 months ago (2017-01-10 21:49:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
204bd5a932b4f15abd5a10e8966fb118d2535701 (presubmit successful).