Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
262673002:
Fix EXPECT_EQ() parameter order in file_util_unittest.cc. (Closed)
|
Created:
6 years, 7 months ago by Thiemo Nagel Modified:
6 years, 7 months ago Reviewers:
willchan no longer on Chromium CC:
chromium-reviews, erikwright+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionFix EXPECT_EQ() parameter order in file_util_unittest.cc.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268171
Patch Set 1 #Patch Set 2 : Rebase. #Patch Set 3 : Fix compilation. #Messages
Total messages: 22 (0 generated)
Hi Will, this is to fix the surrounding code. Could you please take a look? Thank you! Thiemo
lgtm, thanks!
On 2014/04/30 17:17:47, willchan wrote: > lgtm, thanks! Thank you, too.
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/262673002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clang_dbg on tryserver.chromium
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/262673002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium ios_rel_device on tryserver.chromium ios_rel_device_ninja on tryserver.chromium
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/262673002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium ios_rel_device on tryserver.chromium ios_rel_device_ninja on tryserver.chromium
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/262673002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/262673002/40001
Message was sent while issue was closed.
Change committed as 268171 |
