Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2626723004: Update OCMock to 3e193f3c2d4ea4ada63df54c8ce98e7ea4cf768f (Closed)

Created:
3 years, 11 months ago by gambard
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, vabr+watchlistpasswordmanager_chromium.org, tfarina, pkl (ping after 24h if needed), noyau+watch_chromium.org, mac-reviews_chromium.org, marq+watch_chromium.org, chromium-apps-reviews_chromium.org, gcasto+watchlist_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update OCMock to 3e193f3c2d4ea4ada63df54c8ce98e7ea4cf768f BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3680 lines, -1029 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/passwords/password_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/passwords/password_generation_agent_unittest.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/ocmock/BUILD.gn View 4 chunks +31 lines, -5 lines 0 comments Download
M third_party/ocmock/OCMock/NSInvocation+OCMAdditions.h View 1 chunk +37 lines, -24 lines 0 comments Download
M third_party/ocmock/OCMock/NSInvocation+OCMAdditions.m View 19 chunks +108 lines, -74 lines 0 comments Download
M third_party/ocmock/OCMock/NSMethodSignature+OCMAdditions.h View 1 chunk +21 lines, -10 lines 0 comments Download
M third_party/ocmock/OCMock/NSMethodSignature+OCMAdditions.m View 1 chunk +143 lines, -9 lines 0 comments Download
M third_party/ocmock/OCMock/NSNotificationCenter+OCMAdditions.h View 1 chunk +17 lines, -6 lines 0 comments Download
M third_party/ocmock/OCMock/NSNotificationCenter+OCMAdditions.m View 2 chunks +17 lines, -5 lines 0 comments Download
A third_party/ocmock/OCMock/NSObject+OCMAdditions.h View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/NSObject+OCMAdditions.m View 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/NSValue+OCMAdditions.h View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/NSValue+OCMAdditions.m View 1 chunk +107 lines, -0 lines 0 comments Download
M third_party/ocmock/OCMock/OCClassMockObject.h View 1 chunk +18 lines, -5 lines 0 comments Download
M third_party/ocmock/OCMock/OCClassMockObject.m View 4 chunks +247 lines, -7 lines 0 comments Download
M third_party/ocmock/OCMock/OCMArg.h View 3 chunks +29 lines, -8 lines 0 comments Download
M third_party/ocmock/OCMock/OCMArg.m View 5 chunks +56 lines, -10 lines 0 comments Download
A third_party/ocmock/OCMock/OCMArgAction.h View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMArgAction.m View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMBlockArgCaller.h View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMBlockArgCaller.m View 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/ocmock/OCMock/OCMBlockCaller.h View 2 chunks +15 lines, -6 lines 0 comments Download
M third_party/ocmock/OCMock/OCMBlockCaller.m View 2 chunks +24 lines, -10 lines 0 comments Download
M third_party/ocmock/OCMock/OCMBoxedReturnValueProvider.h View 1 chunk +15 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/OCMBoxedReturnValueProvider.m View 1 chunk +31 lines, -201 lines 0 comments Download
M third_party/ocmock/OCMock/OCMConstraint.h View 2 chunks +19 lines, -12 lines 0 comments Download
M third_party/ocmock/OCMock/OCMConstraint.m View 4 chunks +33 lines, -17 lines 0 comments Download
M third_party/ocmock/OCMock/OCMExceptionReturnValueProvider.h View 1 chunk +17 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/OCMExceptionReturnValueProvider.m View 1 chunk +19 lines, -5 lines 0 comments Download
A third_party/ocmock/OCMock/OCMExpectationRecorder.h View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMExpectationRecorder.m View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMFunctions.h View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMFunctions.m View 1 chunk +295 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMFunctionsPrivate.h View 1 chunk +50 lines, -0 lines 0 comments Download
M third_party/ocmock/OCMock/OCMIndirectReturnValueProvider.h View 1 chunk +15 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/OCMIndirectReturnValueProvider.m View 2 chunks +29 lines, -8 lines 0 comments Download
A third_party/ocmock/OCMock/OCMInvocationExpectation.h View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMInvocationExpectation.m View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMInvocationMatcher.h View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMInvocationMatcher.m View 1 chunk +148 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMInvocationStub.h View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMInvocationStub.m View 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMLocation.h View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMLocation.m View 1 chunk +66 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMMacroState.h View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMMacroState.m View 1 chunk +112 lines, -0 lines 0 comments Download
M third_party/ocmock/OCMock/OCMNotificationPoster.h View 1 chunk +15 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/OCMNotificationPoster.m View 2 chunks +20 lines, -6 lines 0 comments Download
M third_party/ocmock/OCMock/OCMObserverRecorder.h View 1 chunk +15 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/OCMObserverRecorder.m View 2 chunks +26 lines, -14 lines 0 comments Download
M third_party/ocmock/OCMock/OCMPassByRefSetter.h View 1 chunk +17 lines, -8 lines 0 comments Download
M third_party/ocmock/OCMock/OCMPassByRefSetter.m View 3 chunks +25 lines, -8 lines 0 comments Download
M third_party/ocmock/OCMock/OCMRealObjectForwarder.h View 1 chunk +15 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/OCMRealObjectForwarder.m View 2 chunks +31 lines, -12 lines 0 comments Download
A third_party/ocmock/OCMock/OCMRecorder.h View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMRecorder.m View 1 chunk +109 lines, -0 lines 0 comments Download
M third_party/ocmock/OCMock/OCMReturnValueProvider.h View 2 chunks +16 lines, -5 lines 0 comments Download
M third_party/ocmock/OCMock/OCMReturnValueProvider.m View 2 chunks +33 lines, -11 lines 0 comments Download
A third_party/ocmock/OCMock/OCMStubRecorder.h View 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMStubRecorder.m View 1 chunk +187 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMVerifier.h View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMVerifier.m View 1 chunk +48 lines, -0 lines 0 comments Download
M third_party/ocmock/OCMock/OCMock.h View 1 chunk +81 lines, -5 lines 0 comments Download
M third_party/ocmock/OCMock/OCMock-Info.plist View 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/ocmock/OCMock/OCMock-Prefix.pch View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/ocmock/OCMock/OCMockObject.h View 3 chunks +40 lines, -9 lines 0 comments Download
M third_party/ocmock/OCMock/OCMockObject.m View 4 chunks +223 lines, -102 lines 0 comments Download
D third_party/ocmock/OCMock/OCMockRecorder.h View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/ocmock/OCMock/OCMockRecorder.m View 1 chunk +0 lines, -187 lines 0 comments Download
M third_party/ocmock/OCMock/OCObserverMockObject.h View 2 chunks +27 lines, -6 lines 0 comments Download
M third_party/ocmock/OCMock/OCObserverMockObject.m View 4 chunks +60 lines, -16 lines 0 comments Download
M third_party/ocmock/OCMock/OCPartialMockObject.h View 2 chunks +15 lines, -12 lines 0 comments Download
M third_party/ocmock/OCMock/OCPartialMockObject.m View 2 chunks +161 lines, -85 lines 0 comments Download
D third_party/ocmock/OCMock/OCPartialMockRecorder.h View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/ocmock/OCMock/OCPartialMockRecorder.m View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/ocmock/OCMock/OCProtocolMockObject.h View 1 chunk +15 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/OCProtocolMockObject.m View 3 chunks +24 lines, -14 lines 0 comments Download
A third_party/ocmock/OCMock/en.lproj/InfoPlist.strings View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/ocmock/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ocmock/ocmock_extensions.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ocmock/ocmock_extensions.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (4 generated)
gambard
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-11 15:29:35 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626723004/1
3 years, 11 months ago (2017-01-11 15:30:01 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-11 15:37:06 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 15:37:07 UTC) #4 
Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Powered by Google App Engine
This is Rietveld 408576698