Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2626703002: Roll buildtools to get GN 442631 (Closed)

Created:
3 years, 11 months ago by brettw
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools to get GN 442631 717182cd794a Fix a GN race condition. 4ce240b3ecb8 Associate xctest files with corresponding xctest targets. 7e5894a9a070 Configure xctest build settings to prevent Xcode from linking objects. 043a15ddcc6c Add functionality to find xctest files under application target. d1316080967d Stop propagation of dependent configs between toolchains. 0c1dd9de8c00 GN: Fix some typos in the documentation. 67e8c60e4b18 [Refactor Xcode Objects] Allow extra attributes for native targets. 8fb7d9d9c9dd [Refactor Xcode Objects] Enable adding per file '--help' compiler flag. 898a56b7966c [Refactor Xcode Objects] Decouple file references and indexing target. a8936b7a13ff Fix a typo in GN documentation 889ccd0f81e2 Fix a typo in gn help. 7d88638248b1 Support for source_target_relative expansion in GN 615f852746f6 Fix GN bootstrap. d48f4812d853 [Refactor Xcode Objects] Enable navigator paths for file references. 44dbd2f12ae5 Clean up link references in //tools/gn/README.md. TBR=dpranke@chromium.org BUG=674213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
brettw
3 years, 11 months ago (2017-01-10 18:48:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626703002/1
3 years, 11 months ago (2017-01-10 18:48:53 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/133179)
3 years, 11 months ago (2017-01-10 18:58:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626703002/1
3 years, 11 months ago (2017-01-11 20:18:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/192505)
3 years, 11 months ago (2017-01-11 20:38:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626703002/1
3 years, 11 months ago (2017-01-11 21:07:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/191923) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 11 months ago (2017-01-11 21:12:03 UTC) #13
Dirk Pranke
3 years, 8 months ago (2017-04-06 19:52:24 UTC) #15
Message was sent while issue was closed.
Closing this as no longer needed ...

Powered by Google App Engine
This is Rietveld 408576698