Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: tools/gn/secondary/build/config/BUILDCONFIG.gn

Issue 26267003: Add the concept of a source set to GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/secondary/build/config/BUILDCONFIG.gn
diff --git a/tools/gn/secondary/build/config/BUILDCONFIG.gn b/tools/gn/secondary/build/config/BUILDCONFIG.gn
index e48f8968e3d58e60fcce5ebad48d30503668b055..d2e609daca838ba764dfb49cba9a7cd630fc3583 100644
--- a/tools/gn/secondary/build/config/BUILDCONFIG.gn
+++ b/tools/gn/secondary/build/config/BUILDCONFIG.gn
@@ -162,7 +162,7 @@ set_sources_assignment_filter(sources_assignment_filter)
if (is_component_build) {
component_mode = "shared_library"
} else {
- component_mode = "static_library"
+ component_mode = "source_set"
scottmg 2013/10/08 18:42:03 I don't think this is going to be enough, at least
brettw 2013/10/08 20:17:04 We can continue this on the mailing list. I'm goin
}
toolkit_uses_gtk = is_linux
@@ -266,6 +266,10 @@ set_defaults("shared_library") {
}
}
+set_defaults("source_set") {
+ configs = native_compiler_configs
+}
+
# ==============================================================================
# TOOLCHAIN SETUP
# ==============================================================================

Powered by Google App Engine
This is Rietveld 408576698