Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/ninja_target_writer.cc

Issue 26267003: Add the concept of a source set to GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/ninja_binary_target_writer.h ('K') | « tools/gn/ninja_script_target_writer_unittest.cc ('k') | tools/gn/output_file.h » ('j') | tools/gn/secondary/build/config/BUILDCONFIG.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_target_writer.cc
diff --git a/tools/gn/ninja_target_writer.cc b/tools/gn/ninja_target_writer.cc
index 82a022edde4916fdd80932e62d1b3a29e10bc554..3eccb180973bf05f501f92b809f6a2b4b82fd244 100644
--- a/tools/gn/ninja_target_writer.cc
+++ b/tools/gn/ninja_target_writer.cc
@@ -79,7 +79,8 @@ void NinjaTargetWriter::RunAndWriteFile(const Target* target) {
writer.Run();
} else if (target->output_type() == Target::EXECUTABLE ||
target->output_type() == Target::STATIC_LIBRARY ||
- target->output_type() == Target::SHARED_LIBRARY) {
+ target->output_type() == Target::SHARED_LIBRARY ||
+ target->output_type() == Target::SOURCE_SET) {
NinjaBinaryTargetWriter writer(target, file);
writer.Run();
} else {
« tools/gn/ninja_binary_target_writer.h ('K') | « tools/gn/ninja_script_target_writer_unittest.cc ('k') | tools/gn/output_file.h » ('j') | tools/gn/secondary/build/config/BUILDCONFIG.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698