Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4764)

Unified Diff: chrome/browser/android/ntp/content_suggestions_notification_helper.cc

Issue 2626643002: Stop showing notifications if they're ignored (Closed)
Patch Set: String.equals() Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/ntp/content_suggestions_notification_helper.cc
diff --git a/chrome/browser/android/ntp/content_suggestions_notification_helper.cc b/chrome/browser/android/ntp/content_suggestions_notification_helper.cc
index db5abdd3b659d21147ce6a302283ebbb834b695f..ccfdc9e27ccd67fd17fd2b1d048902e258e5cb6b 100644
--- a/chrome/browser/android/ntp/content_suggestions_notification_helper.cc
+++ b/chrome/browser/android/ntp/content_suggestions_notification_helper.cc
@@ -8,20 +8,39 @@
#include "base/android/jni_android.h"
#include "base/android/jni_string.h"
+#include "base/metrics/histogram_macros.h"
#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/ntp_snippets/ntp_snippets_features.h"
+#include "chrome/browser/ntp_snippets/ntp_snippets_metrics.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/common/pref_names.h"
+#include "components/prefs/pref_service.h"
+#include "components/variations/variations_associated_data.h"
#include "jni/ContentSuggestionsNotificationHelper_jni.h"
#include "ui/gfx/android/java_bitmap.h"
#include "ui/gfx/image/image.h"
#include "ui/gfx/image/image_skia.h"
+using base::android::JavaParamRef;
+
namespace ntp_snippets {
-void ContentSuggestionsNotificationHelper::OpenURL(const GURL& url) {
- JNIEnv* env = base::android::AttachCurrentThread();
- Java_ContentSuggestionsNotificationHelper_openUrl(
- env, base::android::ConvertUTF8ToJavaString(env, url.spec()));
+namespace {
+
+bool IsDisabledForProfile(Profile* profile) {
+ PrefService* prefs = profile->GetPrefs();
+ int current =
+ prefs->GetInteger(prefs::kContentSuggestionsConsecutiveIgnoredPrefName);
+ int limit = variations::GetVariationParamByFeatureAsInt(
+ kContentSuggestionsNotificationsFeature,
+ kContentSuggestionsNotificationsIgnoredLimitParam,
+ kContentSuggestionsNotificationsIgnoredDefaultLimit);
+ return current >= limit;
}
+} // namespace
+
void ContentSuggestionsNotificationHelper::SendNotification(
const GURL& url,
const base::string16& title,
@@ -50,4 +69,59 @@ void ContentSuggestionsNotificationHelper::HideAllNotifications() {
Java_ContentSuggestionsNotificationHelper_hideAllNotifications(env);
}
+void ContentSuggestionsNotificationHelper::FlushCachedMetrics() {
+ JNIEnv* env = base::android::AttachCurrentThread();
+ Java_ContentSuggestionsNotificationHelper_flushCachedMetrics(env);
+}
+
+bool ContentSuggestionsNotificationHelper::IsDisabledForProfile(
+ Profile* profile) {
+ return ntp_snippets::IsDisabledForProfile(profile);
+}
+
+// static
+bool ContentSuggestionsNotificationHelper::Register(JNIEnv* env) {
+ return RegisterNativesImpl(env);
+}
+
+static void ReceiveFlushedMetrics(JNIEnv* env,
+ const JavaParamRef<jclass>& class_object,
+ jint tap_count,
+ jint dismissal_count,
+ jint hide_deadline_count,
+ jint consecutive_ignored) {
+ DVLOG(1) << "Flushing metrics: tap_count=" << tap_count
+ << "; dismissal_count=" << dismissal_count
+ << "; hide_deadline_count=" << hide_deadline_count
+ << "; consecutive_ignored=" << consecutive_ignored;
+ Profile* profile = ProfileManager::GetLastUsedProfile()->GetOriginalProfile();
+ PrefService* prefs = profile->GetPrefs();
+
+ for (int i = 0; i < tap_count; ++i) {
+ RecordContentSuggestionsNotificationAction(CONTENT_SUGGESTIONS_TAP);
+ }
+ for (int i = 0; i < dismissal_count; ++i) {
+ RecordContentSuggestionsNotificationAction(CONTENT_SUGGESTIONS_DISMISSAL);
+ }
+ for (int i = 0; i < hide_deadline_count; ++i) {
+ RecordContentSuggestionsNotificationAction(
+ CONTENT_SUGGESTIONS_HIDE_DEADLINE);
+ }
+
+ const bool was_disabled = IsDisabledForProfile(profile);
+ if (tap_count == 0) {
+ // There were no taps, consecutive_ignored has not been reset and continues
+ // from where it left off. If there was a tap, then Java has provided us
+ // with the number of ignored notifications since that point.
+ consecutive_ignored +=
+ prefs->GetInteger(prefs::kContentSuggestionsConsecutiveIgnoredPrefName);
+ }
+ prefs->SetInteger(prefs::kContentSuggestionsConsecutiveIgnoredPrefName,
+ consecutive_ignored);
+ const bool is_disabled = IsDisabledForProfile(profile);
+ if (!was_disabled && is_disabled) {
+ RecordContentSuggestionsNotificationOptOut(CONTENT_SUGGESTIONS_IMPLICIT);
+ }
+}
+
} // namespace ntp_snippets

Powered by Google App Engine
This is Rietveld 408576698