chrome/browser/ntp_snippets/ntp_snippets_prefs.h - Issue 2626643002: Stop showing notifications if they're ignored

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ntp_snippets/ntp_snippets_prefs.h

Issue 2626643002: Stop showing notifications if they're ignored (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ntp_snippets/ntp_snippets_metrics.h ('K') | « chrome/browser/ntp_snippets/ntp_snippets_metrics.cc ('k') | chrome/browser/ntp_snippets/ntp_snippets_prefs.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_NTP_SNIPPETS_NTP_SNIPPETS_PREFS_H_

	6 #define CHROME_BROWSER_NTP_SNIPPETS_NTP_SNIPPETS_PREFS_H_

	7

	8 extern const char kContentSuggestionsConsecutiveIgnoredPrefName[];
	Bernhard Bauer 2017/01/11 15:21:49 Prefs in chrome/ go in chrome/common/pref_names.{h Prefs in chrome/ go in chrome/common/pref_names.{h,cc} (this also goes for kNotificationIDWithinCategory, which I should have caught previously; sorry). sfiera 2017/01/11 15:41:52 Should the registration code also move somewhere e Show quoted text On 2017/01/11 15:21:49, Bernhard Bauer wrote: > Prefs in chrome/ go in chrome/common/pref_names.{h,cc} (this also goes for > kNotificationIDWithinCategory, which I should have caught previously; sorry). Should the registration code also move somewhere else? kNotificationIDWithinCategory is going to go away so that we can track multiple notifications. Should it still move, if we're just going to get rid of it? Bernhard Bauer 2017/01/11 15:58:24 No, registration is in the same place where the pr Show quoted text On 2017/01/11 15:41:52, sfiera wrote: > On 2017/01/11 15:21:49, Bernhard Bauer wrote: > > Prefs in chrome/ go in chrome/common/pref_names.{h,cc} (this also goes for > > kNotificationIDWithinCategory, which I should have caught previously; sorry). > > Should the registration code also move somewhere else? No, registration is in the same place where the pref is used, just the names themselves are declared in a single location. Show quoted text > kNotificationIDWithinCategory is going to go away so that we can track multiple > notifications. Should it still move, if we're just going to get rid of it? No, that's fine then.
	9

	10 #endif // CHROME_BROWSER_NTP_SNIPPETS_NTP_SNIPPETS_PREFS_H_

OLD	NEW