chrome/browser/ntp_snippets/ntp_snippets_features.cc - Issue 2626643002: Stop showing notifications if they're ignored

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ntp_snippets/ntp_snippets_features.cc

Issue 2626643002: Stop showing notifications if they're ignored (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ntp_snippets/ntp_snippets_features.h"	5 #include "chrome/browser/ntp_snippets/ntp_snippets_features.h"

6	6

7 const base::Feature kContentSuggestionsNotificationsFeature = {	7 const base::Feature kContentSuggestionsNotificationsFeature = {

8 "ContentSuggestionsNotifications", base::FEATURE_DISABLED_BY_DEFAULT};	8 "ContentSuggestionsNotifications", base::FEATURE_DISABLED_BY_DEFAULT};

9	9

10 const char kContentSuggestionsNotificationsAlwaysNotifyParam[] =	10 const char kContentSuggestionsNotificationsAlwaysNotifyParam[] =

11 "always_notify";	11 "always_notify";

	12 extern const char kContentSuggestionsNotificationsIgnoredLimitParam[] =
	Bernhard Bauer 2017/01/11 15:21:49 Do you need to repeat the extern if it's already o Do you need to repeat the extern if it's already on the declaration? sfiera 2017/01/11 15:41:52 No, removed. Show quoted text On 2017/01/11 15:21:49, Bernhard Bauer wrote: > Do you need to repeat the extern if it's already on the declaration? No, removed.
	13 "ignored_limit";

OLD	NEW