Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2626613002: More offsets in kernel (Closed)

Created:
3 years, 11 months ago by jensj
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More offsets in kernel Added offsets to more nodes. Added end offsets to some nodes. Added functionnode debuggability flag. This changes the dill format. The new offsets et al. are read on the C++ side, but not used for anything usefull yet. This is step #2 in introducing these things, next step(s) will be using it on the C++ side. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/414d66dce65a876a8106f7dc884e06edf8b8155a

Patch Set 1 #

Patch Set 2 : Removed debugging stuff #

Total comments: 2

Patch Set 3 : Fixed FileOffset storage for classes in binary.md #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -32 lines) Patch
M pkg/kernel/binary.md View 1 2 13 chunks +21 lines, -0 lines 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 12 chunks +48 lines, -13 lines 0 comments Download
M pkg/kernel/lib/binary/ast_to_binary.dart View 1 23 chunks +32 lines, -11 lines 0 comments Download
M runtime/vm/kernel.h View 12 chunks +30 lines, -8 lines 0 comments Download
M runtime/vm/kernel_binary.cc View 30 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jensj
3 years, 11 months ago (2017-01-10 11:43:10 UTC) #2
asgerf
lgtm https://codereview.chromium.org/2626613002/diff/20001/pkg/kernel/binary.md File pkg/kernel/binary.md (right): https://codereview.chromium.org/2626613002/diff/20001/pkg/kernel/binary.md#newcode111 pkg/kernel/binary.md:111: FileOffset fileOffset; This type describes a reference to ...
3 years, 11 months ago (2017-01-10 11:57:09 UTC) #3
jensj
https://codereview.chromium.org/2626613002/diff/20001/pkg/kernel/binary.md File pkg/kernel/binary.md (right): https://codereview.chromium.org/2626613002/diff/20001/pkg/kernel/binary.md#newcode111 pkg/kernel/binary.md:111: FileOffset fileOffset; On 2017/01/10 11:57:09, asgerf wrote: > This ...
3 years, 11 months ago (2017-01-10 12:01:56 UTC) #4
jensj
3 years, 11 months ago (2017-01-11 09:00:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
414d66dce65a876a8106f7dc884e06edf8b8155a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698