third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js - Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js b/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

index ce9487f845750fec9bfe8459605f2f37dbe50f1c..925f28aabaf896c4e373e71e8e2800fc1e04d4f3 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

@@ -101,7 +101,7 @@ Network.ResourceWebSocketFrameView = class extends UI.VBox {

_frameAdded(event) {

var frame = /** @type {!SDK.NetworkRequest.WebSocketFrame} */ (event.data);

- this._dataGrid.insertChild(new Network.ResourceWebSocketFrameNode(this._request.url, frame));

+ this._dataGrid.insertChild(new Network.ResourceWebSocketFrameNode(this._request.url(), frame));

}

/**

@@ -148,7 +148,7 @@ Network.ResourceWebSocketFrameView = class extends UI.VBox {

this._dataGrid.rootNode().removeChildren();

var frames = this._request.frames();

for (var i = 0; i < frames.length; ++i)

- this._dataGrid.insertChild(new Network.ResourceWebSocketFrameNode(this._request.url, frames[i]));

+ this._dataGrid.insertChild(new Network.ResourceWebSocketFrameNode(this._request.url(), frames[i]));

}

_sortItems() {