third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-conversion.html - Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-conversion.html

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-conversion.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-conversion.html b/third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-conversion.html

index 2dcdd00d22802dbccbd9e7049c7d779b051426cf..dbbc6b2ec80dc65bdaec56ddba70b4f6e74f0617 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-conversion.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-conversion.html

@@ -34,7 +34,7 @@ var test = function()

{

var requests = InspectorTest.networkRequests();

for (var i = 0; i < requests.length; ++i) {

- if (url.test(requests[i].url))

+ if (url.test(requests[i].url()))

return requests[i];

}