third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-replay.html - Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-replay.html

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-redirect-method.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-sync.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-replay.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-replay.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-replay.html

index 6e4d11ad82608cffe4368dae7379724586b5f4c8..c8f083e9c90828ac3d8f647947a4ef62631536a0 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-replay.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-replay.html

@@ -14,7 +14,7 @@ function test()

function dumpRequest(request)

{

InspectorTest.addResult("Dumping request: ");

- InspectorTest.addResult(" url: " + request.url);

+ InspectorTest.addResult(" url: " + request.url());

if (request.requestFormData)

InspectorTest.addResult(" requestFormData: " + request.requestFormData);

InspectorTest.addResult(" requestMethod: " + request.requestMethod);

@@ -23,7 +23,7 @@ function test()

function assertRequestEqual(request1, request2)

{

- InspectorTest.assertEquals(request1.url, request2.url, "Requests have different url");

+ InspectorTest.assertEquals(request1.url(), request2.url(), "Requests have different url");

InspectorTest.assertEquals(request1.requestFormData, request2.requestFormData, "Requests have different requestFormData");

InspectorTest.assertEquals(request1.requestMethod, request2.requestMethod, "Requests have different requestMethod");

InspectorTest.assertEquals(request1.requestHeadersText, request2.requestHeadersText, "Requests have different requestHeadersText");