third_party/WebKit/LayoutTests/http/tests/inspector/network/network-timing.html - Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-timing.html

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/network-request-revision-content.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-async.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-timing.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-timing.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-timing.html

index f585497d336fab3020a5cd16104ad71d92c851a8..a864e84c116eb77a046b9fdb4a30d56b0268b283 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-timing.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-timing.html

@@ -36,12 +36,12 @@ function test()

var requests = InspectorTest.networkRequests();

var requestsCount = requests.length;

var request1 = requests[requestsCount - 2];

- InspectorTest.addResult(request1.url);

+ InspectorTest.addResult(request1.url());

InspectorTest.assertGreaterOrEqual(request1.latency * 1000, 100 - timerThreshold, "Latency of the first resource");

InspectorTest.assertGreaterOrEqual(request1.duration * 1000, 300 - timerThreshold, "Duration of the first resource");

var request2 = requests[requestsCount - 1];

- InspectorTest.addResult(request2.url);

+ InspectorTest.addResult(request2.url());

InspectorTest.assertGreaterOrEqual(request2.latency * 1000, 100 - timerThreshold, "Latency of the second resource");

InspectorTest.assertGreaterOrEqual(request2.duration * 1000, 100 - timerThreshold, "Duration of the second resource");

InspectorTest.completeTest();