third_party/WebKit/LayoutTests/http/tests/inspector/network/network-memory-cached-resource.html - Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-memory-cached-resource.html

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator-from-console.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/network-request-revision-content.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-memory-cached-resource.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-memory-cached-resource.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-memory-cached-resource.html

index 6c01a8a7abe23ddc188f4978a8841c21e0c99384..ad7200f0ef2d72d0bf831af2bd0f5378c997da62 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-memory-cached-resource.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-memory-cached-resource.html

@@ -20,7 +20,7 @@ function test()

var requests = InspectorTest.networkRequests();

for (var i = 0; i < requests.length; ++i) {

var request = requests[i];

- if (url.test(request.url) && (status === request.statusCode) && (cached === request.cached()))

+ if (url.test(request.url()) && (status === request.statusCode) && (cached === request.cached()))

return request;

}

return null;