Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-image-404.html

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-image-404.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-image-404.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-image-404.html
index 53a23b7d024c6b50948341776b811a3711745311..6721c37f558d14917b988b78ec197d866f677bc2 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-image-404.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-image-404.html
@@ -24,7 +24,7 @@ function test()
function step2()
{
var request1 = InspectorTest.networkRequests().pop();
- InspectorTest.addResult(request1.url);
+ InspectorTest.addResult(request1.url());
InspectorTest.addResult("resource.type: " + request1.resourceType());
InspectorTest.addResult("resource.content before requesting content: " + request1.content);
InspectorTest.assertTrue(!request1.failed, "Resource loading failed.");
@@ -34,10 +34,10 @@ function test()
function step3()
{
var requests = InspectorTest.networkRequests();
- requests.sort(function(a, b) {return a.url.localeCompare(b.url);});
+ requests.sort(function(a, b) {return a.url().localeCompare(b.url());});
InspectorTest.addResult("resources count = " + requests.length);
for (i = 0; i < requests.length; i++) {
- InspectorTest.addResult(requests[i].url);
+ InspectorTest.addResult(requests[i].url());
InspectorTest.addResult("resource.content after requesting content: " + requests[i].content);
}

Powered by Google App Engine
This is Rietveld 408576698