third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html - Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/network-cyrillic-xhr.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/network-disable-cache-cors.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html

index 2ed2c63d275940769e7ef43a40391d52b53e52e9..3a979d8a4ab3d733fdf4135a13ecae8d5e966b0e 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html

@@ -22,7 +22,7 @@ function test()

function responseReceived(requestId, frameId, loaderId, time, resourceType, response)

{

var request = InspectorTest.networkLog.requestForId(requestId);

- if (/resource\.php/.exec(request.url)) {

+ if (/resource\.php/.exec(request.url())) {

InspectorTest.addResult("Received response.");

encodedBytesReceived += response.encodedDataLength;

}

@@ -31,7 +31,7 @@ function test()

function loadingFinished(requestId, finishTime, encodedDataLength)

{

var request = InspectorTest.networkLog.requestForId(requestId);

- if (/resource\.php/.exec(request.url)) {

+ if (/resource\.php/.exec(request.url())) {

InspectorTest.assertEquals(encodedBytesReceived, encodedDataLength, "Data length mismatch");

InspectorTest.addResult("SUCCESS");

InspectorTest.completeTest();

@@ -41,7 +41,7 @@ function test()

function loadingFailed(requestId, time, localizedDescription, canceled)

{

var request = InspectorTest.networkLog.requestForId(requestId);

- if (/resource\.php/.exec(request.url)) {

+ if (/resource\.php/.exec(request.url())) {

InspectorTest.addResult("Loading failed!");

InspectorTest.completeTest();

}

@@ -51,7 +51,7 @@ function test()

{

InspectorTest.addSniffer(SDK.NetworkDispatcher.prototype, "dataReceived", dataReceived);

var request = InspectorTest.networkLog.requestForId(requestId);

- if (/resource\.php/.exec(request.url))

+ if (/resource\.php/.exec(request.url()))

encodedBytesReceived += encodedDataLength;

}