third_party/WebKit/LayoutTests/http/tests/inspector/network-preflight-options.html - Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network-preflight-options.html

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/fragment.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network-preflight-options.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network-preflight-options.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network-preflight-options.html

index 0f8dc6a72ff70724660dee9965f7b05e9490603b..4435eef3c8c1afbd7e0d6d4e33a63faf923d6235 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network-preflight-options.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network-preflight-options.html

@@ -66,9 +66,9 @@ var test = function()

function onRequest(event)

{

var request = event.data;

- var idMatch = /\?id=([0-9]*)&/.exec(request.url);

+ var idMatch = /\?id=([0-9]*)&/.exec(request.url());

var requestId = idMatch[1];

- var requestMessage = requestId + " " + request.resourceType() + ":" + request.requestMethod + " " + request.url.replace(/[&?]date=\d+/, "");

+ var requestMessage = requestId + " " + request.resourceType() + ":" + request.requestMethod + " " + request.url().replace(/[&?]date=\d+/, "");

requestMessages.push(requestMessage);

if (request.requestMethod === "POST" && ++postRequestsCount === 4) {

requestMessages.sort();