Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 885 matching lines...) Expand 10 before | Expand all | Expand 10 after
896 } 896 }
897 897
898 /** 898 /**
899 * @param {!UI.ContextMenu} contextMenu 899 * @param {!UI.ContextMenu} contextMenu
900 * @param {!Object} target 900 * @param {!Object} target
901 */ 901 */
902 _appendNetworkRequestItems(contextMenu, target) { 902 _appendNetworkRequestItems(contextMenu, target) {
903 if (!(target instanceof SDK.NetworkRequest)) 903 if (!(target instanceof SDK.NetworkRequest))
904 return; 904 return;
905 var request = /** @type {!SDK.NetworkRequest} */ (target); 905 var request = /** @type {!SDK.NetworkRequest} */ (target);
906 var uiSourceCode = this._workspace.uiSourceCodeForURL(request.url); 906 var uiSourceCode = this._workspace.uiSourceCodeForURL(request.url());
907 if (!uiSourceCode) 907 if (!uiSourceCode)
908 return; 908 return;
909 var openText = Common.UIString.capitalize('Open in Sources ^panel'); 909 var openText = Common.UIString.capitalize('Open in Sources ^panel');
910 contextMenu.appendItem(openText, this.showUILocation.bind(this, uiSourceCode .uiLocation(0, 0))); 910 contextMenu.appendItem(openText, this.showUILocation.bind(this, uiSourceCode .uiLocation(0, 0)));
911 } 911 }
912 912
913 /** 913 /**
914 * @param {!SDK.RemoteObject} remoteObject 914 * @param {!SDK.RemoteObject} remoteObject
915 */ 915 */
916 _saveToTempVariable(remoteObject) { 916 _saveToTempVariable(remoteObject) {
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
1310 */ 1310 */
1311 willHide() { 1311 willHide() {
1312 UI.inspectorView.setDrawerMinimized(false); 1312 UI.inspectorView.setDrawerMinimized(false);
1313 setImmediate(() => Sources.SourcesPanel.updateResizerAndSidebarButtons(Sourc es.SourcesPanel.instance())); 1313 setImmediate(() => Sources.SourcesPanel.updateResizerAndSidebarButtons(Sourc es.SourcesPanel.instance()));
1314 } 1314 }
1315 1315
1316 _showViewInWrapper() { 1316 _showViewInWrapper() {
1317 this._view.show(this.element); 1317 this._view.show(this.element);
1318 } 1318 }
1319 }; 1319 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698