Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 return entry; 79 return entry;
80 } 80 }
81 81
82 /** 82 /**
83 * @return {!Object} 83 * @return {!Object}
84 */ 84 */
85 _buildRequest() { 85 _buildRequest() {
86 var headersText = this._request.requestHeadersText(); 86 var headersText = this._request.requestHeadersText();
87 var res = { 87 var res = {
88 method: this._request.requestMethod, 88 method: this._request.requestMethod,
89 url: this._buildRequestURL(this._request.url), 89 url: this._buildRequestURL(this._request.url()),
90 httpVersion: this._request.requestHttpVersion(), 90 httpVersion: this._request.requestHttpVersion(),
91 headers: this._request.requestHeaders(), 91 headers: this._request.requestHeaders(),
92 queryString: this._buildParameters(this._request.queryParameters || []), 92 queryString: this._buildParameters(this._request.queryParameters || []),
93 cookies: this._buildCookies(this._request.requestCookies || []), 93 cookies: this._buildCookies(this._request.requestCookies || []),
94 headersSize: headersText ? headersText.length : -1, 94 headersSize: headersText ? headersText.length : -1,
95 bodySize: this.requestBodySize 95 bodySize: this.requestBodySize
96 }; 96 };
97 if (this._request.requestFormData) 97 if (this._request.requestFormData)
98 res.postData = this._buildPostData(); 98 res.postData = this._buildPostData();
99 99
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 * @param {number} time 344 * @param {number} time
345 * @return {number} 345 * @return {number}
346 */ 346 */
347 _pageEventTime(page, time) { 347 _pageEventTime(page, time) {
348 var startTime = page.startTime; 348 var startTime = page.startTime;
349 if (time === -1 || startTime === -1) 349 if (time === -1 || startTime === -1)
350 return -1; 350 return -1;
351 return SDK.HAREntry._toMilliseconds(time - startTime); 351 return SDK.HAREntry._toMilliseconds(time - startTime);
352 } 352 }
353 }; 353 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698