Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Research In Motion Limited. All rights reserved. 2 * Copyright (C) 2012 Research In Motion Limited. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Lesser General Public 5 * modify it under the terms of the GNU Lesser General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 */ 94 */
95 willHide() { 95 willHide() {
96 this._request.removeEventListener(SDK.NetworkRequest.Events.WebsocketFrameAd ded, this._frameAdded, this); 96 this._request.removeEventListener(SDK.NetworkRequest.Events.WebsocketFrameAd ded, this._frameAdded, this);
97 } 97 }
98 98
99 /** 99 /**
100 * @param {!Common.Event} event 100 * @param {!Common.Event} event
101 */ 101 */
102 _frameAdded(event) { 102 _frameAdded(event) {
103 var frame = /** @type {!SDK.NetworkRequest.WebSocketFrame} */ (event.data); 103 var frame = /** @type {!SDK.NetworkRequest.WebSocketFrame} */ (event.data);
104 this._dataGrid.insertChild(new Network.ResourceWebSocketFrameNode(this._requ est.url, frame)); 104 this._dataGrid.insertChild(new Network.ResourceWebSocketFrameNode(this._requ est.url(), frame));
105 } 105 }
106 106
107 /** 107 /**
108 * @param {!Common.Event} event 108 * @param {!Common.Event} event
109 */ 109 */
110 _onFrameSelected(event) { 110 _onFrameSelected(event) {
111 var selectedNode = /** @type {!Network.ResourceWebSocketFrameNode} */ (event .data); 111 var selectedNode = /** @type {!Network.ResourceWebSocketFrameNode} */ (event .data);
112 this._currentSelectedNode = selectedNode; 112 this._currentSelectedNode = selectedNode;
113 var contentProvider = selectedNode.contentProvider(); 113 var contentProvider = selectedNode.contentProvider();
114 contentProvider.requestContent().then(contentHandler.bind(this)); 114 contentProvider.requestContent().then(contentHandler.bind(this));
(...skipping 26 matching lines...) Expand all
141 * @param {!Common.Event} event 141 * @param {!Common.Event} event
142 */ 142 */
143 _onFrameDeselected(event) { 143 _onFrameDeselected(event) {
144 this._currentSelectedNode = null; 144 this._currentSelectedNode = null;
145 } 145 }
146 146
147 refresh() { 147 refresh() {
148 this._dataGrid.rootNode().removeChildren(); 148 this._dataGrid.rootNode().removeChildren();
149 var frames = this._request.frames(); 149 var frames = this._request.frames();
150 for (var i = 0; i < frames.length; ++i) 150 for (var i = 0; i < frames.length; ++i)
151 this._dataGrid.insertChild(new Network.ResourceWebSocketFrameNode(this._re quest.url, frames[i])); 151 this._dataGrid.insertChild(new Network.ResourceWebSocketFrameNode(this._re quest.url(), frames[i]));
152 } 152 }
153 153
154 _sortItems() { 154 _sortItems() {
155 this._dataGrid.sortNodes(this._timeComparator, !this._dataGrid.isSortOrderAs cending()); 155 this._dataGrid.sortNodes(this._timeComparator, !this._dataGrid.isSortOrderAs cending());
156 } 156 }
157 }; 157 };
158 158
159 /** @enum {number} */ 159 /** @enum {number} */
160 Network.ResourceWebSocketFrameView.OpCodes = { 160 Network.ResourceWebSocketFrameView.OpCodes = {
161 ContinuationFrame: 0, 161 ContinuationFrame: 0,
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 }; 240 };
241 241
242 /** 242 /**
243 * @param {!Network.ResourceWebSocketFrameNode} a 243 * @param {!Network.ResourceWebSocketFrameNode} a
244 * @param {!Network.ResourceWebSocketFrameNode} b 244 * @param {!Network.ResourceWebSocketFrameNode} b
245 * @return {number} 245 * @return {number}
246 */ 246 */
247 Network.ResourceWebSocketFrameNodeTimeComparator = function(a, b) { 247 Network.ResourceWebSocketFrameNodeTimeComparator = function(a, b) {
248 return a._frame.time - b._frame.time; 248 return a._frame.time - b._frame.time;
249 }; 249 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698