Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) IBM Corp. 2009 All rights reserved. 3 * Copyright (C) IBM Corp. 2009 All rights reserved.
4 * Copyright (C) 2010 Google Inc. All rights reserved. 4 * Copyright (C) 2010 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 if (value === '') 135 if (value === '')
136 div.classList.add('empty-value'); 136 div.classList.add('empty-value');
137 if (errorDecoding) 137 if (errorDecoding)
138 div.createChild('span', 'header-decode-error').textContent = Common.UIStri ng('(unable to decode value)'); 138 div.createChild('span', 'header-decode-error').textContent = Common.UIStri ng('(unable to decode value)');
139 else 139 else
140 div.textContent = value; 140 div.textContent = value;
141 return div; 141 return div;
142 } 142 }
143 143
144 _refreshURL() { 144 _refreshURL() {
145 this._urlItem.title = this._formatHeader(Common.UIString('Request URL'), thi s._request.url); 145 this._urlItem.title = this._formatHeader(Common.UIString('Request URL'), thi s._request.url());
146 } 146 }
147 147
148 _refreshQueryString() { 148 _refreshQueryString() {
149 var queryString = this._request.queryString(); 149 var queryString = this._request.queryString();
150 var queryParameters = this._request.queryParameters; 150 var queryParameters = this._request.queryParameters;
151 this._queryStringCategory.hidden = !queryParameters; 151 this._queryStringCategory.hidden = !queryParameters;
152 if (queryParameters) { 152 if (queryParameters) {
153 this._refreshParams( 153 this._refreshParams(
154 Common.UIString('Query String Parameters'), queryParameters, queryStri ng, this._queryStringCategory); 154 Common.UIString('Query String Parameters'), queryParameters, queryStri ng, this._queryStringCategory);
155 } 155 }
(...skipping 365 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 this._expandedSetting.set(true); 521 this._expandedSetting.set(true);
522 } 522 }
523 523
524 /** 524 /**
525 * @override 525 * @override
526 */ 526 */
527 oncollapse() { 527 oncollapse() {
528 this._expandedSetting.set(false); 528 this._expandedSetting.set(false);
529 } 529 }
530 }; 530 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698