Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 570 matching lines...) Expand 10 before | Expand all | Expand 10 after
581 var maxTime = -1; 581 var maxTime = -1;
582 var nodes = this._nodesByRequestId.valuesArray(); 582 var nodes = this._nodesByRequestId.valuesArray();
583 for (var i = 0; i < nodes.length; ++i) { 583 for (var i = 0; i < nodes.length; ++i) {
584 var request = nodes[i].request(); 584 var request = nodes[i].request();
585 var requestTransferSize = request.transferSize; 585 var requestTransferSize = request.transferSize;
586 transferSize += requestTransferSize; 586 transferSize += requestTransferSize;
587 if (!nodes[i][Network.NetworkLogView._isFilteredOutSymbol]) { 587 if (!nodes[i][Network.NetworkLogView._isFilteredOutSymbol]) {
588 selectedRequestsNumber++; 588 selectedRequestsNumber++;
589 selectedTransferSize += requestTransferSize; 589 selectedTransferSize += requestTransferSize;
590 } 590 }
591 if (request.url === request.target().inspectedURL() && request.resourceTyp e() === Common.resourceTypes.Document) 591 if (request.url() === request.target().inspectedURL() && request.resourceT ype() === Common.resourceTypes.Document)
592 baseTime = request.startTime; 592 baseTime = request.startTime;
593 if (request.endTime > maxTime) 593 if (request.endTime > maxTime)
594 maxTime = request.endTime; 594 maxTime = request.endTime;
595 } 595 }
596 596
597 var summaryBar = this._summaryBarElement; 597 var summaryBar = this._summaryBarElement;
598 summaryBar.removeChildren(); 598 summaryBar.removeChildren();
599 var separator = '\u2002\u2758\u2002'; 599 var separator = '\u2002\u2758\u2002';
600 var text = ''; 600 var text = '';
601 /** 601 /**
(...skipping 990 matching lines...) Expand 10 before | Expand all | Expand 10 after
1592 var encapsChars = /[\r\n]/.test(str) ? '^"' : '"'; 1592 var encapsChars = /[\r\n]/.test(str) ? '^"' : '"';
1593 return encapsChars + 1593 return encapsChars +
1594 str.replace(/\\/g, '\\\\') 1594 str.replace(/\\/g, '\\\\')
1595 .replace(/"/g, '\\"') 1595 .replace(/"/g, '\\"')
1596 .replace(/[^a-zA-Z0-9\s_\-:=+~'\/.',?;()*`]/g, '^$&') 1596 .replace(/[^a-zA-Z0-9\s_\-:=+~'\/.',?;()*`]/g, '^$&')
1597 .replace(/%(?=[a-zA-Z0-9_])/g, '%^') 1597 .replace(/%(?=[a-zA-Z0-9_])/g, '%^')
1598 .replace(/\r\n|[\n\r]/g, '^\n\n') + 1598 .replace(/\r\n|[\n\r]/g, '^\n\n') +
1599 encapsChars; 1599 encapsChars;
1600 } 1600 }
1601 1601
1602 /**
1603 * @param {string} str
1604 * @return {string}
1605 */
1602 function escapeStringPosix(str) { 1606 function escapeStringPosix(str) {
1607 /**
1608 * @param {string} x
1609 * @return {string}
1610 */
1603 function escapeCharacter(x) { 1611 function escapeCharacter(x) {
1604 var code = x.charCodeAt(0); 1612 var code = x.charCodeAt(0);
1605 if (code < 256) { 1613 if (code < 256) {
1606 // Add leading zero when needed to not care about the next character. 1614 // Add leading zero when needed to not care about the next character.
1607 return code < 16 ? '\\x0' + code.toString(16) : '\\x' + code.toString( 16); 1615 return code < 16 ? '\\x0' + code.toString(16) : '\\x' + code.toString( 16);
1608 } 1616 }
1609 code = code.toString(16); 1617 code = code.toString(16);
1610 return '\\u' + ('0000' + code).substr(code.length, 4); 1618 return '\\u' + ('0000' + code).substr(code.length, 4);
1611 } 1619 }
1612 1620
1613 if (/[^\x20-\x7E]|\'/.test(str)) { 1621 if (/[^\x20-\x7E]|\'/.test(str)) {
1614 // Use ANSI-C quoting syntax. 1622 // Use ANSI-C quoting syntax.
1615 return '$\'' + 1623 return '$\'' +
1616 str.replace(/\\/g, '\\\\') 1624 str.replace(/\\/g, '\\\\')
1617 .replace(/\'/g, '\\\'') 1625 .replace(/\'/g, '\\\'')
1618 .replace(/\n/g, '\\n') 1626 .replace(/\n/g, '\\n')
1619 .replace(/\r/g, '\\r') 1627 .replace(/\r/g, '\\r')
1620 .replace(/[^\x20-\x7E]/g, escapeCharacter) + 1628 .replace(/[^\x20-\x7E]/g, escapeCharacter) +
1621 '\''; 1629 '\'';
1622 } else { 1630 } else {
1623 // Use single quote syntax. 1631 // Use single quote syntax.
1624 return '\'' + str + '\''; 1632 return '\'' + str + '\'';
1625 } 1633 }
1626 } 1634 }
1627 1635
1628 // cURL command expected to run on the same platform that DevTools run 1636 // cURL command expected to run on the same platform that DevTools run
1629 // (it may be different from the inspected page platform). 1637 // (it may be different from the inspected page platform).
1630 var escapeString = platform === 'win' ? escapeStringWin : escapeStringPosix; 1638 var escapeString = platform === 'win' ? escapeStringWin : escapeStringPosix;
1631 1639
1632 command.push(escapeString(request.url).replace(/[[{}\]]/g, '\\$&')); 1640 command.push(escapeString(request.url()).replace(/[[{}\]]/g, '\\$&'));
1633 1641
1634 var inferredMethod = 'GET'; 1642 var inferredMethod = 'GET';
1635 var data = []; 1643 var data = [];
1636 var requestContentType = request.requestContentType(); 1644 var requestContentType = request.requestContentType();
1637 if (requestContentType && requestContentType.startsWith('application/x-www-f orm-urlencoded') && 1645 if (requestContentType && requestContentType.startsWith('application/x-www-f orm-urlencoded') &&
1638 request.requestFormData) { 1646 request.requestFormData) {
1639 data.push('--data'); 1647 data.push('--data');
1640 data.push(escapeString(request.requestFormData)); 1648 data.push(escapeString(request.requestFormData));
1641 ignoredHeaders['content-length'] = true; 1649 ignoredHeaders['content-length'] = true;
1642 inferredMethod = 'POST'; 1650 inferredMethod = 'POST';
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
1718 Running: 'running', 1726 Running: 'running',
1719 FromCache: 'from-cache' 1727 FromCache: 'from-cache'
1720 }; 1728 };
1721 1729
1722 /** @type {!Array<string>} */ 1730 /** @type {!Array<string>} */
1723 Network.NetworkLogView._searchKeys = 1731 Network.NetworkLogView._searchKeys =
1724 Object.keys(Network.NetworkLogView.FilterType).map(key => Network.NetworkLog View.FilterType[key]); 1732 Object.keys(Network.NetworkLogView.FilterType).map(key => Network.NetworkLog View.FilterType[key]);
1725 1733
1726 /** @typedef {function(!SDK.NetworkRequest): boolean} */ 1734 /** @typedef {function(!SDK.NetworkRequest): boolean} */
1727 Network.NetworkLogView.Filter; 1735 Network.NetworkLogView.Filter;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698