Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 var args = consoleMessage.parameters || [messageText]; 225 var args = consoleMessage.parameters || [messageText];
226 messageElement = messageElement || this._format(args); 226 messageElement = messageElement || this._format(args);
227 } 227 }
228 } else if (consoleMessage.source === SDK.ConsoleMessage.MessageSource.Networ k) { 228 } else if (consoleMessage.source === SDK.ConsoleMessage.MessageSource.Networ k) {
229 if (consoleMessage.request) { 229 if (consoleMessage.request) {
230 messageElement = createElement('span'); 230 messageElement = createElement('span');
231 if (consoleMessage.level === SDK.ConsoleMessage.MessageLevel.Error || 231 if (consoleMessage.level === SDK.ConsoleMessage.MessageLevel.Error ||
232 consoleMessage.level === SDK.ConsoleMessage.MessageLevel.RevokedErro r) { 232 consoleMessage.level === SDK.ConsoleMessage.MessageLevel.RevokedErro r) {
233 messageElement.createTextChild(consoleMessage.request.requestMethod + ' '); 233 messageElement.createTextChild(consoleMessage.request.requestMethod + ' ');
234 messageElement.appendChild(Components.Linkifier.linkifyRevealable( 234 messageElement.appendChild(Components.Linkifier.linkifyRevealable(
235 consoleMessage.request, consoleMessage.request.url, consoleMessage .request.url)); 235 consoleMessage.request, consoleMessage.request.url(), consoleMessa ge.request.url()));
236 if (consoleMessage.request.failed) { 236 if (consoleMessage.request.failed) {
237 messageElement.createTextChildren(' ', consoleMessage.request.locali zedFailDescription); 237 messageElement.createTextChildren(' ', consoleMessage.request.locali zedFailDescription);
238 } else { 238 } else {
239 messageElement.createTextChildren( 239 messageElement.createTextChildren(
240 ' ', String(consoleMessage.request.statusCode), ' (', consoleMes sage.request.statusText, ')'); 240 ' ', String(consoleMessage.request.statusCode), ' (', consoleMes sage.request.statusText, ')');
241 } 241 }
242 } else { 242 } else {
243 var fragment = 243 var fragment =
244 Components.linkifyStringAsFragmentWithCustomLinkifier(messageText, linkifyRequest.bind(consoleMessage)); 244 Components.linkifyStringAsFragmentWithCustomLinkifier(messageText, linkifyRequest.bind(consoleMessage));
245 messageElement.appendChild(fragment); 245 messageElement.appendChild(fragment);
(...skipping 19 matching lines...) Expand all
265 formattedMessage.appendChild(messageElement); 265 formattedMessage.appendChild(messageElement);
266 return formattedMessage; 266 return formattedMessage;
267 267
268 /** 268 /**
269 * @param {string} title 269 * @param {string} title
270 * @return {!Element} 270 * @return {!Element}
271 * @this {SDK.ConsoleMessage} 271 * @this {SDK.ConsoleMessage}
272 */ 272 */
273 function linkifyRequest(title) { 273 function linkifyRequest(title) {
274 return Components.Linkifier.linkifyRevealable( 274 return Components.Linkifier.linkifyRevealable(
275 /** @type {!SDK.NetworkRequest} */ (this.request), title, this.request .url); 275 /** @type {!SDK.NetworkRequest} */ (this.request), title, this.request .url());
276 } 276 }
277 } 277 }
278 278
279 /** 279 /**
280 * @param {!SDK.ConsoleMessage} consoleMessage 280 * @param {!SDK.ConsoleMessage} consoleMessage
281 * @return {?Element} 281 * @return {?Element}
282 */ 282 */
283 _buildMessageAnchor(consoleMessage) { 283 _buildMessageAnchor(consoleMessage) {
284 var anchorElement = null; 284 var anchorElement = null;
285 if (consoleMessage.source !== SDK.ConsoleMessage.MessageSource.Network || co nsoleMessage.request) { 285 if (consoleMessage.source !== SDK.ConsoleMessage.MessageSource.Network || co nsoleMessage.request) {
(...skipping 979 matching lines...) Expand 10 before | Expand all | Expand 10 after
1265 toMessageElement() { 1265 toMessageElement() {
1266 if (!this._element) { 1266 if (!this._element) {
1267 super.toMessageElement(); 1267 super.toMessageElement();
1268 this._expandGroupIcon = UI.Icon.create('', 'expand-group-icon'); 1268 this._expandGroupIcon = UI.Icon.create('', 'expand-group-icon');
1269 this._contentElement.insertBefore(this._expandGroupIcon, this._contentElem ent.firstChild); 1269 this._contentElement.insertBefore(this._expandGroupIcon, this._contentElem ent.firstChild);
1270 this.setCollapsed(this._collapsed); 1270 this.setCollapsed(this._collapsed);
1271 } 1271 }
1272 return this._element; 1272 return this._element;
1273 } 1273 }
1274 }; 1274 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698